Remove overdue tests from My Isaac notification count

Copy f3fcf97 and necessary parts of 9da86f7 to master.

Author: axlewin

src/app/components/navigation/NavigationBar.tsx

@@ -19,6 +19,7 @@ import {
     isAda,
     isFound,
     isNotPartiallyLoggedIn,
+    isOverdue,
     isPhy,
     partitionCompleteAndIncompleteQuizzes,
     siteSpecific
@@ -93,7 +94,7 @@ export function useAssignmentsCount() {
         ? filterAssignmentsByStatus(assignments).inProgressRecent.length
         : 0;
     const quizzesCount = quizAssignments && isFound(quizAssignments)
-        ? partitionCompleteAndIncompleteQuizzes(quizAssignments)[1].length
+        ? partitionCompleteAndIncompleteQuizzes(quizAssignments)[1].filter(q => !isOverdue(q)).length
         : 0;
 
     return {assignmentsCount, quizzesCount};

src/app/services/assignments.ts

@@ -1,4 +1,4 @@
-import {AssignmentDTO} from "../../IsaacApiTypes";
+import {AssignmentDTO, IAssignmentLike} from "../../IsaacApiTypes";
 import orderBy from "lodash/orderBy";
 import {EnhancedAssignment} from "../../IsaacAppTypes";
 import {API_PATH, extractTeacherName, matchesAllWordsInAnyOrder} from "./";
@@ -15,13 +15,13 @@ function createAssignmentWithStartDate(assignment: AssignmentDTO): AssignmentDTO
     return {...assignment, startDate: assignmentStartDate};
 }
 
+const now = new Date();
+const midnightLastNight = new Date(now);
+midnightLastNight.setHours(0, 0, 0, 0);
+
 type AssignmentStatus = "inProgressRecent" | "inProgressOld" | "allAttempted" | "allCorrect";
 export const filterAssignmentsByStatus = (assignments: AssignmentDTO[] | undefined | null) => {
-    const now = new Date();
     const fourWeeksAgo = new Date(now.valueOf() - (4 * 7 * 24 * 60 * 60 * 1000));
-    // Midnight last night:
-    const midnightLastNight = new Date(now);
-    midnightLastNight.setHours(0, 0, 0, 0);
 
     const myAssignments: Record<AssignmentStatus, (AssignmentDTO & {startDate: Date})[]> = {
         inProgressRecent: [],
@@ -104,3 +104,5 @@ export const getDistinctAssignmentSetters = (assignments: AssignmentDTO[] | unde
 export const getAssignmentStartDate = (a: AssignmentDTO): number => (a.scheduledStartDate ?? a.creationDate ?? 0).valueOf();
 
 export const hasAssignmentStarted = (a: AssignmentDTO): boolean => getAssignmentStartDate(a) <= Date.now();
+
+export const isOverdue = (a: IAssignmentLike) =>  a.dueDate && a.dueDate < midnightLastNight;