Merge pull request #1241 from isaacphysics/improvement/code-scanning-useless-code-2024

Remove useless code detected by ESLint

Author: axlewin

src/app/components/content/IsaacGlossaryTerm.tsx

@@ -2,8 +2,6 @@ import React, {Ref} from 'react';
 import {Col, Row} from "reactstrap";
 import {GlossaryTermDTO} from "../../../IsaacApiTypes";
 import {IsaacContent} from "./IsaacContent";
-import {isAda, isDefined, TAG_ID, tags} from "../../services";
-import {Tag} from '../../../IsaacAppTypes';
 import {formatGlossaryTermId} from "../pages/Glossary";
 
 interface IsaacGlossaryTermProps {
@@ -13,11 +11,6 @@ interface IsaacGlossaryTermProps {
 }
 
 const IsaacGlossaryTermComponent = ({doc, inPortal, linkToGlossary}: IsaacGlossaryTermProps, ref: Ref<any>) => {
-    let _tags: Tag[] = [];
-    if (isAda && doc.tags) {
-        _tags = doc.tags.map(id => tags.getById(id as TAG_ID)).filter(tag => isDefined(tag));
-    }
-
     const termContents = <>
         <Col md={3} className="glossary_term_name">
             <p ref={ref}>
@@ -31,7 +24,6 @@ const IsaacGlossaryTermComponent = ({doc, inPortal, linkToGlossary}: IsaacGlossa
         </Col>
         <Col md={7}>
             {doc.explanation && <IsaacContent doc={doc.explanation} />}
-            {/* {_tags && _tags.length > 0 && <p className="topics">Used in: {_tags.map(tag => tag.title).join(', ')}</p>} */}
         </Col>
     </>;
 

src/app/components/elements/inputs/UserEmailPreferencesInput.tsx

@@ -67,7 +67,7 @@ export const UserEmailPreferencesInput = ({emailPreferences, setEmailPreferences
                             />
                         </td>
                     </tr>
-                    {isPhy && <tr>
+                    {<tr>
                         <td className="form-required">Events</td>
                         <td className="d-none d-sm-table-cell">
                             {isaacEmailPreferenceDescriptions.events}

src/app/components/pages/Equality.tsx

@@ -350,7 +350,7 @@ const Equality = withRouter(({location}: RouteComponentProps<{}, {}, {board?: st
                     <pre>{currentAttemptValue?.result?.uniqueSymbols}</pre>
                     {(segueEnvironment === "DEV" || isStaff(user)) && <>
                         <h4>Inequality seed</h4>
-                        <pre>{currentAttemptValue && currentAttemptValue.symbols && JSON.stringify(currentAttemptValue.symbols)}</pre>
+                        <pre>{currentAttemptValue.symbols && JSON.stringify(currentAttemptValue.symbols)}</pre>
                     </>}
                 </Col>
             </Row>}

src/app/components/pages/Gameboard.tsx

@@ -100,7 +100,7 @@ const GameboardItemComponent = ({gameboard, question}: {gameboard: GameboardDTO,
                     <Markup encoding={"latex"} className={classNames( "question-link-title", {"text-secondary": isPhy})}>
                         {generateQuestionTitle(question)}
                     </Markup>
-                    {isPhy && message && <span className={"gameboard-item-message" + (isPhy ? "-phy " : " ") + messageClasses}>{message}</span>}
+                    {isPhy && message && <span className={classNames("gameboard-item-message-phy", messageClasses)}>{message}</span>}
                     {isPhy && question.subtitle && <div className="small text-muted d-none d-sm-block">
                         {question.subtitle}
                     </div>}

src/app/services/userViewingContext.ts

@@ -307,7 +307,7 @@ export function determineAudienceViews(audience?: AudienceContext[], creationCon
         viewsFilteredByCreationContext = allViews.filter(viewingContext => {
             let viableView = true;
             if (creationContext.stage && viewingContext.stage) {
-                viableView = viableView && creationContext.stage.includes(viewingContext.stage);
+                viableView = creationContext.stage.includes(viewingContext.stage);
             }
             if (creationContext.examBoard && viewingContext.examBoard) {
                 viableView = viableView && creationContext.examBoard.includes(viewingContext.examBoard);