remove "Instructions" heading from all test pages

Headings will be part of the content, so they can be customized for each
test.

Author: barna-isaac

src/app/components/elements/quiz/QuizContentsComponent.tsx

@@ -166,7 +166,6 @@ function QuizRubric({attempt, view}: Pick<QuizAttemptProps | QuizViewProps, "att
     const renderRubric = (rubric?.children || []).length > 0;
     return <div>
         {rubric && renderRubric && <div data-testid="quiz-rubric">
-            {!view && <h4>Instructions</h4>}
             <IsaacContentValueOrChildren value={rubric.value}>
                 {rubric.children}
             </IsaacContentValueOrChildren>

src/test/pages/QuizAttempt.test.tsx

@@ -1,7 +1,7 @@
-import { expectLinkWithEnabledBackwardsNavigation, expectH1, expectH4, expectTitledSection, expectUrl } from "../testUtils";
+import { expectLinkWithEnabledBackwardsNavigation, expectH1, expectH4, expectUrl } from "../testUtils";
 import {mockAttempts} from "../../mocks/data";
 import { siteSpecific } from "../../app/services";
-import { expectActionMessage, expectBreadcrumbs, expectErrorMessage, renderQuizPage, testSectionsHeader } from "../helpers/quiz";
+import { expectActionMessage, expectBreadcrumbs, expectErrorMessage, expectRubric, renderQuizPage, testSectionsHeader } from "../helpers/quiz";
 
 describe("QuizAttempt", () => {
     const quizId = Object.keys(mockAttempts)[0];
@@ -29,7 +29,7 @@ describe("QuizAttempt", () => {
 
         it('shows quiz rubric', async () => {
             await studentAttemptsQuiz();
-            expectTitledSection("Instructions", attempt.quiz?.rubric?.children?.[0].value);
+            expectRubric(attempt.quiz?.rubric?.children?.[0].value);
         });
 
         it("shows Test sections that load section and allow navigating back", async () => {

src/test/pages/QuizPreview.test.tsx

@@ -1,7 +1,7 @@
-import { expectLinkWithEnabledBackwardsNavigation, expectH1, expectH4, expectTitledSection, expectUrl } from "../testUtils";
+import { expectLinkWithEnabledBackwardsNavigation, expectH1, expectH4, expectUrl } from "../testUtils";
 import {mockPreviews} from "../../mocks/data";
 import { siteSpecific } from "../../app/services";
-import { expectActionMessage, expectBreadcrumbs, expectErrorMessage, renderQuizPage, testSectionsHeader } from "../helpers/quiz";
+import { expectActionMessage, expectBreadcrumbs, expectErrorMessage, expectRubric, renderQuizPage, testSectionsHeader } from "../helpers/quiz";
 
 describe("QuizPreview", () => {
     const quizId = Object.keys(mockPreviews)[0];
@@ -29,7 +29,7 @@ describe("QuizPreview", () => {
 
         it('shows quiz rubric', async () => {
             await teacherPreviewsQuiz();
-            expectTitledSection("Instructions", preview.rubric?.children?.[0].value);
+            expectRubric(preview.rubric?.children?.[0].value);
         });
 
         it("shows Test sections that load section and allow navigating back", async () => {

src/test/testUtils.tsx

@@ -205,15 +205,6 @@ export const expectH4 = expectHeading(4);
 
 export const expectTextInElementWithId = (testId: string) => (msg: string) => expect(screen.getByTestId(testId)).toHaveTextContent(msg);
 
-export const expectTitledSection = (title: string, message: string | undefined) => {
-    const titleE = screen.getByRole('heading', { name: title });
-    if (titleE.parentElement === null) {
-        throw new Error(`Could not find parent for heading: ${title}`);
-    }
-    const [paragraph] = within(titleE.parentElement).getAllByRole('paragraph');
-    return expect(paragraph).toHaveTextContent(`${message}`);
-}
-;
 export const expectLinkWithEnabledBackwardsNavigation = async (text: string | undefined, targetHref: string, originalHref: string) => {
     if (text === undefined) {
         throw new Error("Target text is undefined");