Skip to content

Ada school year refresh - homepage updates #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Conversation

mwtrew
Copy link
Contributor

@mwtrew mwtrew commented Jul 25, 2024

No description provided.

mwtrew added 2 commits July 25, 2024 15:03
Updates hero, benefits slice, question finder slice and resources slice
copy, and removes Scotland and CS stories slices.

New resources slice uses a bullet list which isn't supported by
IsaacCardDeck, so this was re-created ad hoc.
@mwtrew mwtrew marked this pull request as ready for review July 25, 2024 13:13
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.13%. Comparing base (2e02498) to head (edf678f).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
- Coverage   37.14%   37.13%   -0.01%     
==========================================
  Files         420      421       +1     
  Lines       18544    18557      +13     
  Branches     6095     6084      -11     
==========================================
+ Hits         6888     6892       +4     
- Misses      11037    11046       +9     
  Partials      619      619              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mlt47 mlt47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have access to the RPF G Doc to compare but looks reasonable.
Made a couple of suggestions to consider.

@mwtrew mwtrew merged commit 445e5d9 into master Aug 6, 2024
4 checks passed
@mwtrew mwtrew deleted the ada-homepage-updates branch August 6, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants