Skip to content

Exam specification directory page #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Exam specification directory page #1024

merged 2 commits into from
Aug 2, 2024

Conversation

mwtrew
Copy link
Contributor

@mwtrew mwtrew commented Jul 26, 2024

No description provided.

mwtrew added 2 commits July 26, 2024 14:53
This allows the component to be re-used when we create separate pages
for different countries.
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 45.71429% with 19 lines in your changes missing coverage. Please review.

Project coverage is 37.18%. Comparing base (2e02498) to head (9f3560f).
Report is 4 commits behind head on master.

Files Patch % Lines
src/app/components/pages/ExamSpecifications.tsx 30.76% 18 Missing ⚠️
...p/components/pages/ExamSpecificationsDirectory.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1024      +/-   ##
==========================================
+ Coverage   37.14%   37.18%   +0.04%     
==========================================
  Files         420      421       +1     
  Lines       18544    18561      +17     
  Branches     6095     5473     -622     
==========================================
+ Hits         6888     6902      +14     
- Misses      11037    11620     +583     
+ Partials      619       39     -580     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwtrew mwtrew marked this pull request as ready for review July 26, 2024 14:39
Copy link
Contributor

@mlt47 mlt47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment on lines +89 to +90
<TrackedRoute key={key++} exact path="/exam_specifications_england" component={ExamSpecifications} />,
<TrackedRoute key={key++} exact path="/exam_specifications_wales" component={ExamSpecifications} componentProps={{'examBoardFilter': [EXAM_BOARD.WJEC]}} />,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to add a <Redirect key={key++} from="/exam_specifications_scotland" to="/concepts/sqa_computing_science" /> if you don't want to feel left out!

@mlt47 mlt47 merged commit 72797bb into master Aug 2, 2024
4 checks passed
@mlt47 mlt47 deleted the feature/exam-spec-page branch August 2, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants