Skip to content

Question finder redesign #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 62 commits into from
Aug 13, 2024
Merged

Question finder redesign #1026

merged 62 commits into from
Aug 13, 2024

Conversation

skyepurchase
Copy link
Contributor

No description provided.

jacbn and others added 30 commits July 3, 2024 15:25
Minor addition to elements.scss to fix changes by bootstrap 5.
Add "clear all" option when filters are set (barring revision mode) and
add indicator to open or close all the filter options.
@mwtrew mwtrew self-requested a review August 8, 2024 12:51
Copy link
Contributor

@mwtrew mwtrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

One other thing I noticed is that the CollapsibleLists towards the bottom of Topics filters don't seem to open correctly and/or some of the items are cut off.

</div>}
/>
</div>
{/* TODO: implement new completeness filters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general rule it's best not to merge commented-out code, it has a habit of hanging around and confusing things if priorities change!

@mwtrew mwtrew merged commit d696702 into master Aug 13, 2024
4 checks passed
@mwtrew mwtrew deleted the question-finder-redesign branch August 13, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants