Redesign My Assignments page #1283
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const [limit, setLimit] = useState(INITIAL_NO_ASSIGNMENTS); | ||
|
|
||
| const pageHelp = <span> | ||
| Any {siteSpecific("assignments", "quizzes")} you have been set will appear here.<br /> |
There was a problem hiding this comment.
I'm leaving the siteSpecifics in here for now as I have a feeling we'll be merging these back again eventually.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## redesign-2024 #1283 +/- ##
=================================================
- Coverage 36.27% 36.18% -0.10%
=================================================
Files 468 469 +1
Lines 20386 20477 +91
Branches 6688 6017 -671
=================================================
+ Hits 7396 7410 +14
- Misses 12329 13029 +700
+ Partials 661 38 -623 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good - I've made a couple of (very) minor suggestions, but I like the overall feel.
In terms of code neatness I'm wondering if the student dashboard assignment cards ought to be refactored to use some of the scss you've added here to avoid duplication, but that doesn't affect this PR.
To address your comments: I think the "% attempted/complete" look fine as they are, adding more colour here might be overwhelming. I do think ordering of assignments by due dates is a good idea, especially since we already do this for tests.
Any date fields in an `AssignmentDTO`s can be of type `number`. We were usually getting around this with `.valueOf`, but we ought to fix the type so we can't introduce errors.
Points of note:
DateString.ts) is worth a particular look. Are there any edge cases here?Any other design feedback welcome. There's not much to go off, so be as opinionated as you'd like.