Skip to content

Allow loading of old-style coordinate answers #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

jsharkey13
Copy link
Member

Moving to using an array means we don't load the x and y values from existing answers. This supports doing that, whilst cleaning the updated choice so that if it is submitted again there is no sign of the old-style properties.

Moving to using an array means we don't load the x and y values from
existing answers. This supports doing that, whilst cleaning the updated
choice so that if it is submitted again there is no sign of the
old-style properties.
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 36.48%. Comparing base (fd8b29a) to head (d979d6d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...app/components/content/IsaacCoordinateQuestion.tsx 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
- Coverage   36.52%   36.48%   -0.04%     
==========================================
  Files         456      456              
  Lines       19837    19855      +18     
  Branches     6503     6508       +5     
==========================================
  Hits         7245     7245              
- Misses      12554    12572      +18     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwtrew mwtrew merged commit 23ae196 into master Jan 28, 2025
8 checks passed
@mwtrew mwtrew deleted the feature/support-old-coord-answers branch January 28, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants