Skip to content

Add PREFER_MATHML preference for screenreader users #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

jsharkey13
Copy link
Member

Currently we fall back to MathML if we fail to generate screenreader text. But some accessibility tool users find the MathML alternative more useful than the generated text.
Using a user preference will allow us to test this before committing to any changes.

Currently we fall back to MathML if we fail to generate screenreader
text. But some accessibility tool users find the MathML alternative more
useful than the generated text.
Using a user preference will allow us to test this before committing to
any changes.
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.68%. Comparing base (933fd1c) to head (87c1ef9).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...pp/components/elements/panels/UserBetaFeatures.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1301    +/-   ##
========================================
  Coverage   36.68%   36.68%            
========================================
  Files         456      456            
  Lines       19854    19858     +4     
  Branches     5856     6509   +653     
========================================
+ Hits         7283     7285     +2     
- Misses      12533    12535     +2     
  Partials       38       38            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jsharkey13 and others added 3 commits February 10, 2025 10:31
@jsharkey13 jsharkey13 marked this pull request as ready for review February 10, 2025 10:49
@jacbn jacbn merged commit 9ff20c5 into master Feb 10, 2025
8 checks passed
@jacbn jacbn deleted the feature/mathml-accessibility-preference branch February 10, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants