-
Notifications
You must be signed in to change notification settings - Fork 5
Redesign question page #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign question page #1325
Conversation
Haven't quite finalised design yet, left some comments in for alternative possible variations
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## redesign-2024 #1325 +/- ##
=================================================
- Coverage 36.46% 36.42% -0.04%
=================================================
Files 476 476
Lines 21105 21142 +37
Branches 6989 7006 +17
=================================================
+ Hits 7695 7702 +7
- Misses 12753 12783 +30
Partials 657 657 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small things but much cleaner! It's nice seeing major pages like this come together 🥳
(Not actually touched on here and we've already discussed in-person briefly, but to note it somewhere): I really don't like how hints are displayed on single-part questions. Without a background to act as enclosure, they feel too disconnected from the Hint buttons - especially with the page credit right below.
On a similar note, expanding these hints on <= "sm"
screens causes the buttons to rise rather than the buttons remaining stationary and the hint contents coming down. I've at least figured out the specific problem in this case is to do with the sidebar layout and order-0
/order-1
classes. If the main content is first in HTML-order and page-order, this problem doesn't exist, but being first in page-order but second in HTML-order causes this weird rendering. It might be worth enforcing this ordering for content sidebars in TypeScript directly rather than CSS.
The designs are not quite finalised yet; will remove commented code once complete.