Skip to content

Redesign Teacher Features page #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 10, 2025
Merged

Conversation

axlewin
Copy link
Contributor

@axlewin axlewin commented Mar 4, 2025

No description provided.

@axlewin
Copy link
Contributor Author

axlewin commented Mar 4, 2025

New TeacherFeatureCard to allow for more control over the image placement than with an IsaacCard. I think the smaller images work better since none of the icons match the new designs, but open to suggestions.

@axlewin axlewin marked this pull request as ready for review March 4, 2025 17:25
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.49%. Comparing base (8d9f338) to head (24d0eea).
Report is 31 commits behind head on redesign-2024.

Files with missing lines Patch % Lines
src/app/components/pages/TeacherFeatures.tsx 28.57% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           redesign-2024    #1338      +/-   ##
=================================================
- Coverage          36.49%   36.49%   -0.01%     
=================================================
  Files                475      475              
  Lines              21029    21032       +3     
  Branches            6226     6226              
=================================================
  Hits                7675     7675              
- Misses             13315    13318       +3     
  Partials              39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacbn jacbn merged commit 2bcd3af into redesign-2024 Mar 10, 2025
8 checks passed
@jacbn jacbn deleted the redesign/page/teacher-features branch March 10, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants