Skip to content

Redesign My Tests page #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 17, 2025
Merged

Redesign My Tests page #1339

merged 15 commits into from
Mar 17, 2025

Conversation

axlewin
Copy link
Contributor

@axlewin axlewin commented Mar 7, 2025

The labels & placeholders for filters on this page still need to be made consistent with those on other quiz/assignment pages, but this will be easier to do separately once all of the relevant pages are done.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 17.85714% with 92 lines in your changes missing coverage. Please review.

Project coverage is 36.21%. Comparing base (d1c3593) to head (517ae7b).
Report is 16 commits behind head on redesign-2024.

Files with missing lines Patch % Lines
src/app/components/pages/quizzes/MyQuizzes.tsx 15.94% 58 Missing ⚠️
...c/app/components/elements/layout/SidebarLayout.tsx 18.75% 26 Missing ⚠️
src/app/services/quiz.ts 27.27% 8 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           redesign-2024    #1339      +/-   ##
=================================================
- Coverage          36.26%   36.21%   -0.05%     
=================================================
  Files                476      476              
  Lines              21244    21309      +65     
  Branches            6314     6335      +21     
=================================================
+ Hits                7704     7717      +13     
- Misses             13501    13553      +52     
  Partials              39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axlewin axlewin marked this pull request as ready for review March 7, 2025 13:26
Copy link
Contributor

@jacbn jacbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a couple of changes to make a couple of things clearer that applied to both the old and new designs, but I like these new ones a lot. Made a couple of suggestions too for things to improve if you'd like.

onChange={() => {
const target = !showCompleted;
setShowCompleted(target);
setQuizStatuses(s => target ? [...s, QuizStatus.Complete, QuizStatus.Overdue] : s.filter(status => ![QuizStatus.Complete, QuizStatus.Overdue].includes(status)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be quite sad to lose this, it sped up working with the filters quite significantly. I wonder if instead we could have two more "broader" filters in the same group as "All" for both "Active" and "Past", and put the rest of the tabs in a dropdown or make them smaller if you need the more fine-grained filtering. Don't worry about it for now though, this works well enough as is; I'll make a card to remind us to take another look when we've completed the bulk of the redesign.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is awkward to use at the moment, "Active" and "Past" would definitely be useful. I wonder if the finer-grained filtering is needed at all; having a dropdown as well as the new-style filters might just be confusing.

@jacbn jacbn merged commit 4554c68 into redesign-2024 Mar 17, 2025
8 checks passed
@jacbn jacbn deleted the redesign/page/my-tests branch March 17, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants