-
Notifications
You must be signed in to change notification settings - Fork 5
Redesign My Tests page #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign My Tests page #1339
Conversation
- Redesign quiz card component - Use My Assignments-style status filters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## redesign-2024 #1339 +/- ##
=================================================
- Coverage 36.26% 36.21% -0.05%
=================================================
Files 476 476
Lines 21244 21309 +65
Branches 6314 6335 +21
=================================================
+ Hits 7704 7717 +13
- Misses 13501 13553 +52
Partials 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also rename quiz sidebar props for consistency
…-react-app into redesign/page/my-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made a couple of changes to make a couple of things clearer that applied to both the old and new designs, but I like these new ones a lot. Made a couple of suggestions too for things to improve if you'd like.
onChange={() => { | ||
const target = !showCompleted; | ||
setShowCompleted(target); | ||
setQuizStatuses(s => target ? [...s, QuizStatus.Complete, QuizStatus.Overdue] : s.filter(status => ![QuizStatus.Complete, QuizStatus.Overdue].includes(status))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will be quite sad to lose this, it sped up working with the filters quite significantly. I wonder if instead we could have two more "broader" filters in the same group as "All" for both "Active" and "Past", and put the rest of the tabs in a dropdown or make them smaller if you need the more fine-grained filtering. Don't worry about it for now though, this works well enough as is; I'll make a card to remind us to take another look when we've completed the bulk of the redesign.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is awkward to use at the moment, "Active" and "Past" would definitely be useful. I wonder if the finer-grained filtering is needed at all; having a dropdown as well as the new-style filters might just be confusing.
The labels & placeholders for filters on this page still need to be made consistent with those on other quiz/assignment pages, but this will be easier to do separately once all of the relevant pages are done.