Skip to content

Subject Overview Pages #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 10, 2025
Merged

Subject Overview Pages #1340

merged 13 commits into from
Mar 10, 2025

Conversation

jacbn
Copy link
Contributor

@jacbn jacbn commented Mar 7, 2025

Implement overview pages for individual subjects.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 26.19048% with 62 lines in your changes missing coverage. Please review.

Project coverage is 36.46%. Comparing base (8d9f338) to head (34aa4f2).
Report is 32 commits behind head on redesign-2024.

Files with missing lines Patch % Lines
src/app/components/pages/SubjectLandingPage.tsx 16.66% 20 Missing ⚠️
src/app/components/pages/SubjectOverviewPage.tsx 37.03% 17 Missing ⚠️
...ents/elements/list-groups/AbstractListViewItem.tsx 0.00% 5 Missing ⚠️
...p/components/pages/subjectLandingPageComponents.ts 16.66% 2 Missing and 3 partials ⚠️
src/app/services/pageContext.ts 28.57% 5 Missing ⚠️
src/app/components/site/phy/NavigationMenuPhy.tsx 25.00% 3 Missing ⚠️
src/app/state/slices/api/eventsApi.ts 0.00% 2 Missing and 1 partial ⚠️
src/app/components/pages/Concepts.tsx 50.00% 1 Missing ⚠️
src/app/components/pages/QuestionFinder.tsx 0.00% 1 Missing ⚠️
src/app/components/pages/QuickQuizzes.tsx 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                Coverage Diff                @@
##           redesign-2024    #1340      +/-   ##
=================================================
- Coverage          36.49%   36.46%   -0.04%     
=================================================
  Files                475      476       +1     
  Lines              21029    21102      +73     
  Branches            6226     6989     +763     
=================================================
+ Hits                7675     7695      +20     
+ Misses             13315    12750     -565     
- Partials              39      657     +618     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@axlewin axlewin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just one (very) minor suggestion.

(The events also aren't loading on these pages or the stage-specific ones, but it doesn't seem to be because of this PR so I think this can be merged as-is.)

Co-authored-by: Alex Lewin <sl2281@cam.ac.uk>
@axlewin axlewin merged commit 9e5bf0b into redesign-2024 Mar 10, 2025
7 checks passed
@axlewin axlewin deleted the redesign/subject-overview-pages branch March 10, 2025 14:32
@jacbn
Copy link
Contributor Author

jacbn commented Mar 10, 2025

The /events page was actually broken, so I have fixed that, but the events themselves are not showing simply because there are no events tagged physics that are upcoming at the moment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants