Redesign: very small improvements #1444
Conversation
This isn't in the designs, but it makes switching to this page from a page with a sidebar less jarring and makes the news pods easier to read on large screens.
…rovements Update VRT baselines
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## redesign-2024 #1444 +/- ##
=================================================
- Coverage 40.73% 40.73% -0.01%
=================================================
Files 494 494
Lines 22026 22031 +5
Branches 7297 7300 +3
=================================================
+ Hits 8972 8974 +2
- Misses 13017 13020 +3
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -15,7 +16,7 @@ export const PrintButton = ({questionPage}: PrintProps ) => { | |||
|
|
|||
| return questionPage ? | |||
| <div className="position-relative"> | |||
| {questionPrintOpen && <div className="action-buttons-popup-container not-mobile"> | |||
| {questionPrintOpen && <div className={classNames("action-buttons-popup-container", {"not-mobile": isAda})}> | |||
There was a problem hiding this comment.
This seems fine, but there are some pages (e.g. Generic.tsx) that use a wrapper div that also has not-mobile for this button (as a relic from the old design), so that should probably be removed in those locations so that this behaviour is consistent across all pages with a print button.
Remove `not-mobile` from wrapper divs on various pages.
…rovements [VRT] Update baselines for redesign/more-misc-improvements
…rovements [VRT] Update baselines for redesign/more-misc-improvements
|
Lots of things being merged into |
…rovements [VRT] Update baselines for redesign/more-misc-improvements
No description provided.