Skip to content

Improve Ada printing behaviour #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2025
Merged

Conversation

sjd210
Copy link
Contributor

@sjd210 sjd210 commented May 14, 2025

  • Fixed behaviour from the redesign causing the [With hints | Without hints] to overlap with the share button in an unreadable way

  • Changed the code snippet "View on GitHub" text to the GitHub link itself when printing

  • Show tab titles above all individual tabs when printing. The original request was for codeTabs specifically, but having tested different options I think this makes sense for all tabs on both sites (helps for a question like sort_31_v2 which isn't using codeTabs (or even something like the About Us page, if you really feel like it)). I also checked viability of doing similar work for our dropdown and button <Tab> styles, but they're less straightforward and don't tend to be used on printable pages anyway.

    Note: I found it was clearer to show all titles with the selected tab highlighted rather than just the name of the selected tab by itself. It helps show that the tabs are collected together in a block.

@sjd210 sjd210 marked this pull request as ready for review May 14, 2025 14:57
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.64%. Comparing base (12d1fc0) to head (5704484).
Report is 136 commits behind head on redesign-2024.

Additional details and impacted files
@@                Coverage Diff                @@
##           redesign-2024    #1449      +/-   ##
=================================================
- Coverage          40.75%   40.64%   -0.12%     
=================================================
  Files                493      494       +1     
  Lines              21991    22031      +40     
  Branches            7309     6517     -792     
=================================================
- Hits                8963     8955       -8     
- Misses             12403    13039     +636     
+ Partials             625       37     -588     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@axlewin axlewin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only issue I can see is that this adds some unnecessary padding above the first code snippet in each section:

Before:
image

After:
image

@sjd210
Copy link
Contributor Author

sjd210 commented May 19, 2025

Oh, nice spot. In which case, I'll bring the padding for the whole heading section more in-line with how it is on the non-print site. It makes it all more consistent this way. (In fact, I think this is what I was trying to do with that rogue mb-2, but clearly I'd forgotten about it)

@axlewin axlewin merged commit f9c08fa into redesign-2024 May 19, 2025
8 checks passed
@axlewin axlewin deleted the redesign/improve-ada-printing branch May 19, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants