Skip to content

Editor tab styles #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2025
Merged

Editor tab styles #1460

merged 5 commits into from
May 19, 2025

Conversation

jacbn
Copy link
Contributor

@jacbn jacbn commented May 16, 2025

Allows changes from this editor branch to allow content-driven tab styling. Also improves the styling of dropdown tabs to be more in line with the designs, and to separate out a small piece of hints logic that was embedded in these tabs.

You can test this here.

Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 40.70%. Comparing base (9354fb6) to head (aa686e9).
Report is 7 commits behind head on redesign-2024.

Files with missing lines Patch % Lines
src/app/components/content/IsaacHints.tsx 0.00% 2 Missing ⚠️
src/app/components/content/IsaacTabs.tsx 60.00% 2 Missing ⚠️
src/app/components/elements/Tabs.tsx 0.00% 2 Missing ⚠️
src/app/components/content/IsaacContent.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           redesign-2024    #1460    +/-   ##
===============================================
  Coverage          40.69%   40.70%            
===============================================
  Files                494      494            
  Lines              22030    22031     +1     
  Branches            7300     6517   -783     
===============================================
+ Hits                8966     8968     +2     
- Misses             12439    13026   +587     
+ Partials             625       37   -588     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…yles

[VRT] Update baselines for redesign/editor-tab-styles
@axlewin axlewin merged commit 986be87 into redesign-2024 May 19, 2025
8 checks passed
@axlewin axlewin deleted the redesign/editor-tab-styles branch May 19, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants