Skip to content

VRT improvements #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2025
Merged

VRT improvements #1462

merged 6 commits into from
May 19, 2025

Conversation

mwtrew
Copy link
Contributor

@mwtrew mwtrew commented May 16, 2025

  • Pass args through to Cypress in vrt-in-docker.py, so individual tests can be run
  • Fail on missing baseline images, which will trigger a VRT update PR for tests which have no existing baseline. This means local baseline generation is not needed.

mwtrew added 3 commits May 16, 2025 10:44
Since this isn't working reliably on Apple silicon, it's important that
initial baselines can be generated bu GitHub Actions. This means
tests with missing baselines will fail, and a VRT PR will be generated.
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.70%. Comparing base (9354fb6) to head (00fa849).
Report is 14 commits behind head on redesign-2024.

Additional details and impacted files
@@              Coverage Diff               @@
##           redesign-2024    #1462   +/-   ##
==============================================
  Coverage          40.69%   40.70%           
==============================================
  Files                494      494           
  Lines              22030    22031    +1     
  Branches            7300     7301    +1     
==============================================
+ Hits                8966     8968    +2     
+ Misses             12439    12438    -1     
  Partials             625      625           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwtrew mwtrew marked this pull request as ready for review May 19, 2025 15:51
@mwtrew mwtrew changed the title Vrt improvements VRT improvements May 19, 2025
@mwtrew mwtrew merged commit 008a6a4 into redesign-2024 May 19, 2025
8 checks passed
@mwtrew mwtrew deleted the vrt-improvements branch May 19, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants