Redesign/improvement/submit inline questions in sequence #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a race condition where the API could not save multiple answers that were submitted at the same time for anonymous users. This is because, for anonymous users, when saving an answer, the API creates a lock using the user's ID, see: https://github.com/isaacphysics/isaac-api/blob/ 51296605cef5b532f6f6b90d9a9575001172d4a6/src/main/java/uk/ac/cam/cl/ dtg/isaac/quiz/PgQuestionAttempts.java#L92.
Previously, the synchronous operations after firing the requests would finish before the requests were actually sent. This meant it was okay to enable error reporting after triggering the request. Now that we wait for the requests to finish, it's important to enable error reporting before firing the requests. It doesn't really matter whether we reset the feedback field before or after the requests were sent, as the box only appears after the last request finishes, but it's still safer to do before sending the requests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## redesign-2024 #1467 +/- ##
=================================================
- Coverage 40.65% 40.65% -0.01%
=================================================
Files 494 494
Lines 22032 22034 +2
Branches 7302 7302
=================================================
Hits 8957 8957
- Misses 12450 13040 +590
+ Partials 625 37 -588 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacbn
approved these changes
May 20, 2025
barna-isaac
deleted the
redesign/improvement/submit-inline-questions-in-sequence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1466