Redesign/general-improvements-9 #1468
Conversation
Fixes a bug with accordion context being stale on non-question/concept/generic pages
| @@ -190,12 +190,15 @@ export const HomepagePhy = () => { | |||
| </div> | |||
| <ShowLoadingQuery | |||
| query={eventsQuery} | |||
| defaultErrorTitle={"Error loading events list"} | |||
| ifError={(() => <p>There was an error loading the events list. Please try again later!</p>)} | |||
There was a problem hiding this comment.
can we use this for events on the subject-stage landing pages too?
| background-color: white; | ||
| box-shadow: 0 2px 30px 0 rgba(0, 0, 0, 0.08); |
There was a problem hiding this comment.
| background-color: white; | |
| box-shadow: 0 2px 30px 0 rgba(0, 0, 0, 0.08); | |
| background-color: white; | |
| border-radius: $border-radius-lg; | |
| box-shadow: 0 2px 30px 0 rgba(0, 0, 0, 0.08); |
minor visual thing with the top corners on accordion-less questions:
There was a problem hiding this comment.
Hm. That CSS block should be switched to the form styling, otherwise it doesn't give a background to hints..? Also fixes that issue as then the outline and border-radius are applied to the same element. Not sure why it wasn't.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## redesign-2024 #1468 +/- ##
=================================================
- Coverage 40.60% 40.59% -0.01%
=================================================
Files 494 495 +1
Lines 22052 22106 +54
Branches 6525 7325 +800
=================================================
+ Hits 8954 8975 +21
- Misses 13061 13094 +33
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…vements-9 [VRT] Update baselines for redesign/general-improvements-9
Yet more bugfixes!
Of the larger changes:
docon page switch so that calls todoc.get(used in various content components to determine the page type) are not stale;<Form/>) so that hints are included and appear in the same "block";