Skip to content

Subject Overview Page cleanup #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: redesign-2024
Choose a base branch
from

Conversation

sjd210
Copy link
Contributor

@sjd210 sjd210 commented May 21, 2025

General changes to line things up with the mock ups for each Subject Overview Page:

  • Adding symbols to explain practice and challenge difficulties
  • Including a greyed out option for GCSE Biology in the card list
    • (+ removing blanks from the card list on small screens)
  • Adding the example question deck to the bottom of the screen.
    • Physics hasn't made one yet. We can confirm it has the same id as the commented one and add it in fairly easily once available.

Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.

Project coverage is 40.54%. Comparing base (4afc7c1) to head (a900e72).
Report is 2 commits behind head on redesign-2024.

Files with missing lines Patch % Lines
src/app/components/pages/SubjectOverviewPage.tsx 38.46% 8 Missing ⚠️
...rc/app/components/elements/svg/DifficultyIcons.tsx 81.81% 2 Missing ⚠️
...ents/elements/list-groups/AbstractListViewItem.tsx 0.00% 1 Missing ⚠️
src/app/components/pages/SubjectLandingPage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           redesign-2024    #1475      +/-   ##
=================================================
- Coverage          40.60%   40.54%   -0.06%     
=================================================
  Files                495      495              
  Lines              22087    22101      +14     
  Branches            6531     7305     +774     
=================================================
- Hits                8968     8961       -7     
+ Misses             13082    12515     -567     
- Partials              37      625     +588     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sjd210 sjd210 marked this pull request as ready for review May 22, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant