General improvements 10 #1483
Merged
General improvements 10 #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove vertical margin from units selection to bring it back in line with the value input. Keep the margin on small screens to correct the caret position.
Remove vertical margin from units selection to bring it back in line with the value input. Keep the margin on small screens to correct the caret position.
…/isaacphysics/isaac-react-app into redesign/general-improvements-10
This is consistent with concept pages, but not all other types of page.
# Conflicts: # src/app/components/elements/Book.tsx # src/app/components/elements/BookPage.tsx
Use the existing "subtitle" property for this, since it will be included in summary objects, etc, already without needing to add an additional "label" attribute right now.
This is important when the intro text is very short to prevent the cover image from touching the footer.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## redesign-2024 #1483 +/- ##
=================================================
- Coverage 40.44% 40.44% -0.01%
=================================================
Files 495 495
Lines 22122 22127 +5
Branches 7312 7357 +45
=================================================
+ Hits 8948 8949 +1
- Misses 12549 12553 +4
Partials 625 625 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…vements-10 [VRT] Update baselines for redesign/general-improvements-10
axlewin
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various additions (by various people) to the redesign. Review on a commit-by-commit basis.
Important changes:
dropdownstab styling by default (Phy only)