Skip to content

Commit 09d02f4

Browse files
committed
[#1945] add missing definition for level 70: DBGLVL_TRACE_ALL
This way, all debug levels used are in src/lib/log/log_dbglevels.* And no algebra is used in determining a log level as was the case in: ``` const int DBG_ALL = DBGLVL_TRACE_DETAIL + 20; ```
1 parent 571cd57 commit 09d02f4

File tree

3 files changed

+20
-16
lines changed

3 files changed

+20
-16
lines changed

src/lib/asiodns/io_fetch.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ namespace asiodns {
4646

4747
const int DBG_IMPORTANT = DBGLVL_TRACE_BASIC;
4848
const int DBG_COMMON = DBGLVL_TRACE_DETAIL;
49-
const int DBG_ALL = DBGLVL_TRACE_DETAIL + 20;
49+
const int DBG_ALL = DBGLVL_TRACE_ALL;
5050

5151
/// @brief IOFetch Data
5252
///

src/lib/log/log_dbglevels.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (C) 2017-2021 Internet Systems Consortium, Inc. ("ISC")
1+
// Copyright (C) 2017-2024 Internet Systems Consortium, Inc. ("ISC")
22
//
33
// This Source Code Form is subject to the terms of the Mozilla Public
44
// License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -20,6 +20,7 @@ extern const int DBGLVL_TRACE_BASIC = 40;
2020
extern const int DBGLVL_TRACE_BASIC_DATA = 45;
2121
extern const int DBGLVL_TRACE_DETAIL = 50;
2222
extern const int DBGLVL_TRACE_DETAIL_DATA = 55;
23+
extern const int DBGLVL_TRACE_ALL = 70;
2324

24-
}
25-
}
25+
} // namespace log
26+
} // namespace isc

src/lib/log/log_dbglevels.h

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (C) 2011-2021 Internet Systems Consortium, Inc. ("ISC")
1+
// Copyright (C) 2011-2024 Internet Systems Consortium, Inc. ("ISC")
22
//
33
// This Source Code Form is subject to the terms of the Mozilla Public
44
// License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -7,7 +7,7 @@
77
#ifndef LOG_DBGLVLS_H
88
#define LOG_DBGLVLS_H
99

10-
/// \file
10+
/// @file
1111
///
1212
/// When a message is logged with DEBUG severity, the debug level associated
1313
/// with the message is also specified. This debug level is a number
@@ -41,43 +41,46 @@
4141
namespace isc {
4242
namespace log {
4343

44-
/// Process startup/shutdown debug messages. Note that these are _debug_
44+
/// @brief Process startup/shutdown debug messages. Note that these are _debug_
4545
/// messages, as other messages related to startup and shutdown may be output
4646
/// with another severity. For example, when the authoritative server starts
4747
/// up, the "server started" message could be output at a severity of INFO.
4848
/// "Server starting" and messages indicating the stages in startup should be
4949
/// debug messages output at this severity.
5050
extern const int DBGLVL_START_SHUT;
5151

52-
/// This debug level is reserved for logging the exchange of messages/commands
52+
/// @brief This debug level is reserved for logging the exchange of messages/commands
5353
/// between processes, including configuration messages.
5454
extern const int DBGLVL_COMMAND;
5555

56-
/// This debug level is reserved for logging the details of packet handling, such
56+
/// @brief This debug level is reserved for logging the details of packet handling, such
5757
/// as dropping the packet for various reasons.
5858
extern const int DBGLVL_PKT_HANDLING;
5959

60-
/// If the commands have associated data, this level is when they are printed.
60+
/// @brief If the commands have associated data, this level is when they are printed.
6161
/// This includes configuration messages.
6262
extern const int DBGLVL_COMMAND_DATA;
6363

6464
// The following constants are suggested values for common operations.
6565
// Depending on the exact nature of the code, modules may or may not use these
6666
// levels.
6767

68-
/// Trace basic operations.
68+
/// @brief Trace basic operations.
6969
extern const int DBGLVL_TRACE_BASIC;
7070

71-
/// Trace data associated with the basic operations.
71+
/// @brief Trace data associated with the basic operations.
7272
extern const int DBGLVL_TRACE_BASIC_DATA;
7373

74-
/// Trace detailed operations.
74+
/// @brief Trace detailed operations.
7575
extern const int DBGLVL_TRACE_DETAIL;
7676

77-
/// Trace data associated with detailed operations.
77+
/// @brief Trace data associated with detailed operations.
7878
extern const int DBGLVL_TRACE_DETAIL_DATA;
7979

80-
} // log namespace
81-
} // isc namespace
80+
/// @brief The highest level of debug logging.
81+
extern const int DBGLVL_TRACE_ALL;
82+
83+
} // log namespace
84+
} // isc namespace
8285

8386
#endif // LOG_DBGLVLS_H

0 commit comments

Comments
 (0)