Skip to content

Commit 3c7b4fa

Browse files
committed
[#3534] Update CONTRIBUTING.md
1 parent b8d8e12 commit 3c7b4fa

File tree

1 file changed

+19
-3
lines changed

1 file changed

+19
-3
lines changed

CONTRIBUTING.md

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,28 @@ Here's a quick list of how to contribute a patch:
1212
or basically anyone from the Kea dev team)
1313
4. **fork Kea code**: go to Kea project page, click [Fork button](https://gitlab.isc.org/isc-projects/kea/forks/new).
1414
If you can't, you didn't complete step 3.
15-
5. **Implement your fix or feature, push code** to your repo. Make sure it compiles, has unit-tests,
15+
5. **Give ISC access to the forked project**. This is required to see pipeline status and to merge code.
16+
From the sidebar on the project page, go to `Manage` -> `Members` -> `Invite members`.
17+
- `Username, name or email address`: `@andrei, @fdupont, @marcin, @mgodzina, @piotrek, @razvan, @slawek, @tmark, @tomek, @wlodek`
18+
- `Select a role`: `Developer`
19+
- Click `Invite`.
20+
6. **Configure Danger**. From the sidebar on the project page, go to `Settings` -> `Access Tokens` -> `Add new token`:
21+
- `Token name`: `danger`
22+
- `Select a role`: `Developer`
23+
- `Select scopes`: `[api]`
24+
- Click `Create project access token`.
25+
- Copy the token's value.
26+
Then, go to `Settings` -> `CI/CD` -> `Variables` -> `Add variable`:
27+
- `Visibility`: `Masked`
28+
- `Key`: `DANGER_GITLAB_API_TOKEN`
29+
- `Value`: copied token value
30+
- Click `Add variable`.
31+
7. **Implement your fix or feature, push code** to your repo. Make sure it compiles, has unit-tests,
1632
is documented and does what it's supposed to do.
17-
6. **Open Merge Request**: go to Kea project [merge requests page](https://gitlab.isc.org/isc-projects/kea/merge_requests),
33+
8. **Open Merge Request**: go to Kea project [merge requests page](https://gitlab.isc.org/isc-projects/kea/merge_requests),
1834
click [New merge request](https://gitlab.isc.org/isc-projects/kea/merge_requests/new). If you
1935
don't see the button, you didn't complete step 3.
20-
7. **Participate in the code review**: Once you submit the MR, someone from ISC will eventually get
36+
9. **Participate in the code review**: Once you submit the MR, someone from ISC will eventually get
2137
to the issue and will review your code. Please make sure you respond to comments. It's likely
2238
you'll be asked to update the code.
2339

0 commit comments

Comments
 (0)