[#3536] removed more duplicated messages

Author: Razvan Becheriu

src/hooks/dhcp/mysql/mysql_cb_dhcp4.cc

@@ -2902,6 +2902,7 @@ class MySqlConfigBackendDHCPv4Impl : public MySqlConfigBackendImpl {
         }
 
         bool reopened = false;
+        bool do_exit = false;
 
         const std::string timer_name = db_reconnect_ctl->timerName();
 
@@ -2913,10 +2914,8 @@ class MySqlConfigBackendDHCPv4Impl : public MySqlConfigBackendImpl {
             // Something is definitely wrong. Did the configuration change
             // somehow and there is no configuration for CB?
             if (!config_ctl) {
-                std::string reason("No CB configuration found!");
-                LOG_ERROR(mysql_cb_logger, MYSQL_CB_RECONNECT_ATTEMPT_FAILED4)
-                        .arg(reason);
-                return (true);
+                do_exit = true;
+                isc_throw(Unexpected, "No CB configuration found!");
             }
 
             // Iterate over the configured DBs and instantiate them.
@@ -2932,6 +2931,9 @@ class MySqlConfigBackendDHCPv4Impl : public MySqlConfigBackendImpl {
         } catch (const std::exception& ex) {
             LOG_ERROR(mysql_cb_logger, MYSQL_CB_RECONNECT_ATTEMPT_FAILED4)
                     .arg(ex.what());
+            if (do_exit) {
+                return (true);
+            }
         }
 
         if (reopened) {

src/hooks/dhcp/mysql/mysql_cb_dhcp6.cc

@@ -3329,6 +3329,7 @@ class MySqlConfigBackendDHCPv6Impl : public MySqlConfigBackendImpl {
         }
 
         bool reopened = false;
+        bool do_exit = false;
 
         const std::string timer_name = db_reconnect_ctl->timerName();
 
@@ -3340,10 +3341,8 @@ class MySqlConfigBackendDHCPv6Impl : public MySqlConfigBackendImpl {
             // Something is definitely wrong. Did the configuration change
             // somehow and there is no configuration for CB?
             if (!config_ctl) {
-                std::string reason("No CB configuration found!");
-                LOG_ERROR(mysql_cb_logger, MYSQL_CB_RECONNECT_ATTEMPT_FAILED6)
-                        .arg(reason);
-                return (true);
+                do_exit = true;
+                isc_throw(Unexpected, "No CB configuration found!");
             }
 
             // Iterate over the configured DBs and instantiate them.
@@ -3359,6 +3358,9 @@ class MySqlConfigBackendDHCPv6Impl : public MySqlConfigBackendImpl {
         } catch (const std::exception& ex) {
             LOG_ERROR(mysql_cb_logger, MYSQL_CB_RECONNECT_ATTEMPT_FAILED6)
                     .arg(ex.what());
+            if (do_exit) {
+                return (true);
+            }
         }
 
         if (reopened) {

src/hooks/dhcp/pgsql/pgsql_cb_dhcp4.cc

@@ -2707,6 +2707,7 @@ class PgSqlConfigBackendDHCPv4Impl : public PgSqlConfigBackendImpl {
         }
 
         bool reopened = false;
+        bool do_exit = false;
 
         const std::string timer_name = db_reconnect_ctl->timerName();
 
@@ -2718,10 +2719,8 @@ class PgSqlConfigBackendDHCPv4Impl : public PgSqlConfigBackendImpl {
             // Something is definitely wrong. Did the configuration change
             // somehow and there is no configuration for CB?
             if (!config_ctl) {
-                std::string reason("No CB configuration found!");
-                LOG_ERROR(pgsql_cb_logger, PGSQL_CB_RECONNECT_ATTEMPT_FAILED4)
-                        .arg(reason);
-                return (true);
+                do_exit = true;
+                isc_throw(Unexpected, "No CB configuration found!");
             }
 
             // Iterate over the configured DBs and instantiate them.
@@ -2737,6 +2736,9 @@ class PgSqlConfigBackendDHCPv4Impl : public PgSqlConfigBackendImpl {
         } catch (const std::exception& ex) {
             LOG_ERROR(pgsql_cb_logger, PGSQL_CB_RECONNECT_ATTEMPT_FAILED4)
                     .arg(ex.what());
+            if (do_exit) {
+                return (true);
+            }
         }
 
         if (reopened) {

src/hooks/dhcp/pgsql/pgsql_cb_dhcp6.cc

@@ -3029,6 +3029,7 @@ class PgSqlConfigBackendDHCPv6Impl : public PgSqlConfigBackendImpl {
         }
 
         bool reopened = false;
+        bool do_exit = false;
 
         const std::string timer_name = db_reconnect_ctl->timerName();
 
@@ -3040,10 +3041,8 @@ class PgSqlConfigBackendDHCPv6Impl : public PgSqlConfigBackendImpl {
             // Something is definitely wrong. Did the configuration change
             // somehow and there is no configuration for CB?
             if (!config_ctl) {
-                std::string reason("No CB configuration found!");
-                LOG_ERROR(pgsql_cb_logger, PGSQL_CB_RECONNECT_ATTEMPT_FAILED6)
-                        .arg(reason);
-                return (true);
+                do_exit = true;
+                isc_throw(Unexpected, "No CB configuration found!");
             }
 
             // Iterate over the configured DBs and instantiate them.
@@ -3059,6 +3058,9 @@ class PgSqlConfigBackendDHCPv6Impl : public PgSqlConfigBackendImpl {
         } catch (const std::exception& ex) {
             LOG_ERROR(pgsql_cb_logger, PGSQL_CB_RECONNECT_ATTEMPT_FAILED6)
                     .arg(ex.what());
+            if (do_exit) {
+                return (true);
+            }
         }
 
         if (reopened) {

tools/exhonerated-duplicate-messages.txt

@@ -93,8 +93,6 @@
     % HA_PAUSE_CLIENT_LISTENER_FAILED: 2
     % LOG_BAD_STREAM: 4
     % LOG_DUPLICATE_MESSAGE_ID: 4
-    % MYSQL_CB_RECONNECT_ATTEMPT_FAILED4: 2
-    % MYSQL_CB_RECONNECT_ATTEMPT_FAILED6: 2
     % NETCONF_GET_CONFIG_FAILED: 4
     % NETCONF_SET_CONFIG_FAILED: 5
     % NETCONF_UPDATE_CONFIG_FAILED: 5
@@ -103,8 +101,6 @@
     % DHCP4_PACKET_PROCESS_STD_EXCEPTION: 4
     % DHCP6_PACKET_PROCESS_EXCEPTION: 4
     % DHCP6_PACKET_PROCESS_STD_EXCEPTION: 4
-    % PGSQL_CB_RECONNECT_ATTEMPT_FAILED4: 2
-    % PGSQL_CB_RECONNECT_ATTEMPT_FAILED6: 2
     % DCTL_CONFIG_FILE_LOAD_FAIL: 2
     % LOG_DUPLICATE_NAMESPACE: 2
     % LOG_NO_MESSAGE_ID: 2