[#3649] Fixed comments

Author: msiodelski

src/hooks/dhcp/high_availability/ha_impl.cc

@@ -350,7 +350,7 @@ HAImpl::lease4Expire(CalloutHandle& callout_handle) {
         if (!subnet4) {
             // No subnet means that we possibly have some stale leases that don't
             // really belong to us. Therefore, there we return early and rely on the
-            // DHCP server to reclaim them. The HA hook has no way to juristiction here.
+            // DHCP server to reclaim them. The HA hook has no jurisdiction here.
             return;
         }
 
@@ -631,7 +631,7 @@ HAImpl::lease6Expire(CalloutHandle& callout_handle) {
         if (!subnet6) {
             // No subnet means that we possibly have some stale leases that don't
             // really belong to us. Therefore, there we return early and rely on the
-            // DHCP server to reclaim them. The HA hook has no way to juristiction here.
+            // DHCP server to reclaim them. The HA hook has no jurisdiction here.
             return;
         }
 

src/hooks/dhcp/high_availability/tests/ha_impl_unittest.cc

@@ -85,21 +85,17 @@ class TestHAImpl : public HAImpl {
 
     /// @brief Mock function checking if the lease should be reclaimed by this server.
     ///
-    /// @param service pointer to the HA service to which the lease belongs.
-    /// @param lease4 pointer to the DHCPv4 lease being reclaimed.
     /// @return true if the DHCPv4 lease should be reclaimed by this server instance,
     /// false otherwise.
-    virtual bool shouldReclaim(const HAServicePtr& service, const Lease4Ptr& lease4) const {
+    virtual bool shouldReclaim(const HAServicePtr& /*service*/, const Lease4Ptr& /*lease4*/) const {
         return (should_reclaim_dhcpv4_lease_);
     }
 
     /// @brief Mock function checking if the lease should be reclaimed by this server.
     ///
-    /// @param service pointer to the HA service to which the lease belongs.
-    /// @param lease6 pointer to the DHCPv4 lease being reclaimed.
     /// @return true if the DHCPv6 lease should be reclaimed by this server instance,
     /// false otherwise.
-    virtual bool shouldReclaim(const HAServicePtr& service, const Lease6Ptr& lease6) const {
+    virtual bool shouldReclaim(const HAServicePtr& /*service*/, const Lease6Ptr& /*lease6*/) const {
         return (should_reclaim_dhcpv6_lease_);
     }
 
@@ -1734,6 +1730,8 @@ TEST_F(HAImplTest, lease4ExpireHubNoSubnet) {
     lease4->subnet_id_ = 7;
     callout_handle->setArgument("lease4", lease4);
 
+    // Reclamation should continue because this server's jurisdiction is
+    // indeterminate.
     test_ha_impl_->should_reclaim_dhcpv4_lease_ = false;
     ASSERT_NO_THROW(test_ha_impl_->lease4Expire(*callout_handle));
     EXPECT_EQ(CalloutHandle::NEXT_STEP_CONTINUE, callout_handle->getStatus());