Skip to content

Commit d1d3e20

Browse files
committed
[#3350] install googletest packages in hammer
1 parent 0103b20 commit d1d3e20

File tree

1 file changed

+14
-22
lines changed

1 file changed

+14
-22
lines changed

hammer.py

Lines changed: 14 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1690,12 +1690,10 @@ def install_packages_local(system, revision, features, check_times, ignore_error
16901690
if 'netconf' in features:
16911691
packages.extend(['cmake', 'git', 'pcre2-devel'])
16921692

1693-
install_pkgs(packages, timeout=300, env=env, check_times=check_times)
1694-
16951693
if 'unittest' in features:
1696-
if int(revision) >= 37:
1697-
install_pkgs(['flex', 'bison'], timeout=300, env=env, check_times=check_times)
1698-
_install_gtest_sources()
1694+
packages.append('gtest')
1695+
1696+
install_pkgs(packages, timeout=300, env=env, check_times=check_times)
16991697

17001698
execute('sudo dnf clean packages', env=env, check_times=check_times)
17011699

@@ -1746,8 +1744,7 @@ def link_pg_config():
17461744
packages.extend(['cmake', 'git', 'pcre2-devel'])
17471745

17481746
if 'unittest' in features:
1749-
packages.append('wget')
1750-
deferred_functions.append(_install_gtest_sources)
1747+
packages.append('gtest')
17511748

17521749
install_pkgs(packages, env=env, check_times=check_times)
17531750

@@ -1798,8 +1795,11 @@ def link_pg_config():
17981795
packages.extend(['cmake', 'git', 'pcre2-devel'])
17991796

18001797
if 'unittest' in features:
1801-
packages.append('wget')
1802-
deferred_functions.append(_install_gtest_sources)
1798+
if revision == '8':
1799+
packages.append('wget')
1800+
deferred_functions.append(_install_gtest_sources)
1801+
else:
1802+
packages.append('gtest')
18031803

18041804
install_pkgs(packages, env=env, timeout=120, check_times=check_times)
18051805

@@ -1833,8 +1833,7 @@ def link_pg_config():
18331833
packages.extend(['cmake', 'git', 'pcre2-devel'])
18341834

18351835
if 'unittest' in features:
1836-
packages.append('wget')
1837-
deferred_functions.append(_install_gtest_sources)
1836+
packages.append('gtest')
18381837

18391838
execute('sudo dnf config-manager --set-enabled crb')
18401839
install_pkgs(packages, env=env, timeout=120, check_times=check_times)
@@ -1851,10 +1850,7 @@ def link_pg_config():
18511850
'texlive', 'texlive-latex-extra', 'tex-gyre'])
18521851

18531852
if 'unittest' in features:
1854-
if revision.startswith('16.'):
1855-
_install_gtest_sources()
1856-
else:
1857-
packages.append('googletest')
1853+
packages.append('googletest')
18581854

18591855
if 'native-pkg' in features:
18601856
packages.extend(['build-essential', 'fakeroot', 'devscripts'])
@@ -1901,11 +1897,7 @@ def link_pg_config():
19011897
'tex-gyre', 'texlive', 'texlive-latex-extra'])
19021898

19031899
if 'unittest' in features:
1904-
if revision == '8':
1905-
# libgtest-dev does not work and googletest is not available
1906-
_install_gtest_sources()
1907-
else:
1908-
packages.append('googletest')
1900+
packages.append('googletest')
19091901

19101902
if 'netconf' in features:
19111903
packages.extend(['cmake', 'git', 'libpcre2-dev'])
@@ -1991,7 +1983,7 @@ def link_pg_config():
19911983
install_pkgs(packages, env=env, timeout=6 * 60, check_times=check_times)
19921984

19931985
if 'unittest' in features:
1994-
_install_gtest_sources()
1986+
packages.append(['googletest'])
19951987

19961988
if 'mysql' in features:
19971989
execute('sudo sysrc mysql_enable="yes"', env=env, check_times=check_times)
@@ -2012,7 +2004,7 @@ def link_pg_config():
20122004
packages.extend(['py3-sphinx py3-sphinx_rtd_theme'])
20132005

20142006
if 'unittest' in features:
2015-
_install_gtest_sources()
2007+
packages.append('gtest')
20162008

20172009
if 'netconf' in features:
20182010
packages.extend(['cmake', 'git', 'pcre2-dev'])

0 commit comments

Comments
 (0)