Skip to content

Commit d2bc7a5

Browse files
author
Razvan Becheriu
committed
[#3578] addressed review comments
1 parent 0178195 commit d2bc7a5

File tree

6 files changed

+69
-77
lines changed

6 files changed

+69
-77
lines changed

src/bin/dhcp4/tests/config_parser_unittest.cc

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,24 +6,24 @@
66

77
#include <config.h>
88

9+
#include <asiolink/addr_utilities.h>
910
#include <cc/command_interpreter.h>
1011
#include <config/http_command_config.h>
12+
#include <dhcp/classify.h>
1113
#include <dhcp/docsis3_option_defs.h>
12-
#include <dhcp/libdhcp++.h>
1314
#include <dhcp/iface_mgr.h>
15+
#include <dhcp/libdhcp++.h>
16+
#include <dhcp/option4_addrlst.h>
1417
#include <dhcp/option_custom.h>
1518
#include <dhcp/option_int.h>
16-
#include <dhcp/option4_addrlst.h>
17-
#include <dhcp/classify.h>
1819
#include <dhcp/testutils/iface_mgr_test_config.h>
19-
#include <dhcp4/json_config_parser.h>
20-
#include <dhcp4/dhcp4_srv.h>
2120
#include <dhcp4/ctrl_dhcp4_srv.h>
22-
#include <asiolink/addr_utilities.h>
23-
#include <dhcpsrv/cfgmgr.h>
21+
#include <dhcp4/dhcp4_srv.h>
22+
#include <dhcp4/json_config_parser.h>
2423
#include <dhcpsrv/cfg_expiration.h>
2524
#include <dhcpsrv/cfg_hosts.h>
2625
#include <dhcpsrv/cfg_subnets4.h>
26+
#include <dhcpsrv/cfgmgr.h>
2727
#include <dhcpsrv/parsers/simple_parser4.h>
2828
#include <dhcpsrv/subnet.h>
2929
#include <dhcpsrv/subnet_selector.h>
@@ -37,25 +37,23 @@
3737
#include <testutils/test_to_element.h>
3838
#include <util/chrono_time_utils.h>
3939
#include <util/doubles.h>
40-
#include "marker_file.h"
41-
#include "test_data_files_config.h"
42-
#include "test_libraries.h"
43-
#include "dhcp4_test_utils.h"
44-
#include "get_config_unittest.h"
45-
#include <gtest/gtest.h>
4640

47-
#include <boost/foreach.hpp>
4841
#include <boost/scoped_ptr.hpp>
49-
#include <fstream>
42+
5043
#include <iostream>
5144
#include <sstream>
5245
#include <string>
5346
#include <vector>
5447

5548
#include <arpa/inet.h>
56-
#include <limits.h>
49+
#include <gtest/gtest.h>
5750
#include <unistd.h>
5851

52+
#include "dhcp4_test_utils.h"
53+
#include "get_config_unittest.h"
54+
#include "marker_file.h"
55+
#include "test_libraries.h"
56+
5957
using namespace isc;
6058
using namespace isc::asiolink;
6159
using namespace isc::config;
@@ -374,7 +372,7 @@ class Dhcp4ParserTest : public LogContentTest {
374372
void configure(std::string config, int expected_code,
375373
std::string exp_error = "") {
376374
ConstElementPtr json;
377-
ASSERT_NO_THROW(json = parseDHCP4(config, true));
375+
ASSERT_NO_THROW_LOG(json = parseDHCP4(config, true));
378376

379377
ConstElementPtr status;
380378
EXPECT_NO_THROW(status = Dhcpv4SrvTest::configure(*srv_, json));
@@ -3843,15 +3841,15 @@ TEST_F(Dhcp4ParserTest, optionCodeNegative) {
38433841

38443842
// Verify that out of bounds option code is rejected in the configuration.
38453843
TEST_F(Dhcp4ParserTest, optionCodeNonUint8) {
3846-
// The valid option codes are uint16_t values so passing
3847-
// uint16_t maximum value incremented by 1 should result
3844+
// The valid option codes are uint8_t values so passing
3845+
// uint8_t maximum value incremented by 1 should result
38483846
// in failure.
38493847
testInvalidOptionParam("257", "code");
38503848
}
38513849

38523850
// Verify that out of bounds option code is rejected in the configuration.
38533851
TEST_F(Dhcp4ParserTest, optionCodeHighNonUint8) {
3854-
// Another check for uint16_t overflow but this time
3852+
// Another check for uint8_t overflow but this time
38553853
// let's pass even greater option code value.
38563854
testInvalidOptionParam("500", "code");
38573855
}

src/bin/dhcp4/tests/get_config_unittest.cc

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,24 @@
99
#include <cc/command_interpreter.h>
1010
#include <cc/data.h>
1111
#include <cc/simple_parser.h>
12-
#include <cc/cfg_to_element.h>
13-
#include <testutils/user_context_utils.h>
1412
#include <dhcp/testutils/iface_mgr_test_config.h>
15-
#include <dhcpsrv/cfgmgr.h>
16-
#include <dhcpsrv/parsers/simple_parser4.h>
17-
#include <dhcp4/dhcp4_srv.h>
1813
#include <dhcp4/ctrl_dhcp4_srv.h>
14+
#include <dhcp4/dhcp4_srv.h>
1915
#include <dhcp4/json_config_parser.h>
2016
#include <dhcp4/tests/dhcp4_test_utils.h>
2117
#include <dhcp4/tests/get_config_unittest.h>
18+
#include <dhcpsrv/cfgmgr.h>
2219
#include <testutils/gtest_utils.h>
23-
24-
#include <boost/algorithm/string.hpp>
25-
#include <gtest/gtest.h>
20+
#include <testutils/user_context_utils.h>
2621

2722
#include <iostream>
28-
#include <string>
29-
#include <sstream>
3023
#include <list>
24+
#include <sstream>
25+
#include <string>
26+
27+
#include <boost/algorithm/string.hpp>
28+
29+
#include <gtest/gtest.h>
3130

3231
using namespace isc::config;
3332
using namespace isc::data;

src/bin/dhcp4/tests/get_config_unittest.cc.skel

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,24 @@
99
#include <cc/command_interpreter.h>
1010
#include <cc/data.h>
1111
#include <cc/simple_parser.h>
12-
#include <cc/cfg_to_element.h>
13-
#include <testutils/user_context_utils.h>
1412
#include <dhcp/testutils/iface_mgr_test_config.h>
15-
#include <dhcpsrv/cfgmgr.h>
16-
#include <dhcpsrv/parsers/simple_parser4.h>
17-
#include <dhcp4/dhcp4_srv.h>
1813
#include <dhcp4/ctrl_dhcp4_srv.h>
14+
#include <dhcp4/dhcp4_srv.h>
1915
#include <dhcp4/json_config_parser.h>
2016
#include <dhcp4/tests/dhcp4_test_utils.h>
2117
#include <dhcp4/tests/get_config_unittest.h>
18+
#include <dhcpsrv/cfgmgr.h>
2219
#include <testutils/gtest_utils.h>
23-
24-
#include <boost/algorithm/string.hpp>
25-
#include <gtest/gtest.h>
20+
#include <testutils/user_context_utils.h>
2621

2722
#include <iostream>
28-
#include <string>
29-
#include <sstream>
3023
#include <list>
24+
#include <sstream>
25+
#include <string>
26+
27+
#include <boost/algorithm/string.hpp>
28+
29+
#include <gtest/gtest.h>
3130

3231
using namespace isc::config;
3332
using namespace isc::data;

src/bin/dhcp6/tests/config_parser_unittest.cc

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,25 @@
66

77
#include <config.h>
88

9+
#include <asiolink/addr_utilities.h>
910
#include <cc/command_interpreter.h>
1011
#include <config/http_command_config.h>
12+
#include <dhcp/classify.h>
1113
#include <dhcp/docsis3_option_defs.h>
14+
#include <dhcp/iface_mgr.h>
1215
#include <dhcp/libdhcp++.h>
16+
#include <dhcp/option6_addrlst.h>
1317
#include <dhcp/option6_ia.h>
14-
#include <dhcp/iface_mgr.h>
1518
#include <dhcp/option_custom.h>
1619
#include <dhcp/option_int.h>
17-
#include <dhcp/option6_addrlst.h>
18-
#include <dhcp/classify.h>
1920
#include <dhcp/testutils/iface_mgr_test_config.h>
20-
#include <dhcp6/json_config_parser.h>
21-
#include <dhcp6/dhcp6_srv.h>
2221
#include <dhcp6/ctrl_dhcp6_srv.h>
23-
#include <asiolink/addr_utilities.h>
24-
#include <dhcpsrv/cfgmgr.h>
22+
#include <dhcp6/dhcp6_srv.h>
23+
#include <dhcp6/json_config_parser.h>
2524
#include <dhcpsrv/cfg_expiration.h>
2625
#include <dhcpsrv/cfg_hosts.h>
2726
#include <dhcpsrv/cfg_subnets6.h>
27+
#include <dhcpsrv/cfgmgr.h>
2828
#include <dhcpsrv/parsers/simple_parser6.h>
2929
#include <dhcpsrv/subnet.h>
3030
#include <dhcpsrv/subnet_selector.h>
@@ -38,25 +38,23 @@
3838
#include <testutils/test_to_element.h>
3939
#include <util/chrono_time_utils.h>
4040
#include <util/doubles.h>
41-
#include "marker_file.h"
42-
#include "test_data_files_config.h"
43-
#include "test_libraries.h"
44-
#include "dhcp6_test_utils.h"
45-
#include "get_config_unittest.h"
46-
#include <gtest/gtest.h>
4741

4842
#include <boost/foreach.hpp>
49-
#include <boost/scoped_ptr.hpp>
50-
#include <fstream>
43+
5144
#include <iostream>
5245
#include <sstream>
5346
#include <string>
5447
#include <vector>
5548

5649
#include <arpa/inet.h>
57-
#include <limits.h>
50+
#include <gtest/gtest.h>
5851
#include <unistd.h>
5952

53+
#include "dhcp6_test_utils.h"
54+
#include "get_config_unittest.h"
55+
#include "marker_file.h"
56+
#include "test_libraries.h"
57+
6058
using namespace isc;
6159
using namespace isc::asiolink;
6260
using namespace isc::config;
@@ -462,7 +460,7 @@ class Dhcp6ParserTest : public LogContentTest {
462460
void configure(std::string config, int expected_code,
463461
std::string exp_error = "") {
464462
ConstElementPtr json;
465-
ASSERT_NO_THROW(json = parseDHCP6(config, true));
463+
ASSERT_NO_THROW_LOG(json = parseDHCP6(config, true));
466464

467465
ConstElementPtr status;
468466
EXPECT_NO_THROW(status = Dhcpv6SrvTest::configure(srv_, json));

src/bin/dhcp6/tests/get_config_unittest.cc

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,24 @@
99
#include <cc/command_interpreter.h>
1010
#include <cc/data.h>
1111
#include <cc/simple_parser.h>
12-
#include <cc/cfg_to_element.h>
13-
#include <testutils/user_context_utils.h>
1412
#include <dhcp/testutils/iface_mgr_test_config.h>
15-
#include <dhcpsrv/cfgmgr.h>
16-
#include <dhcpsrv/parsers/simple_parser6.h>
17-
#include <dhcp6/dhcp6_srv.h>
1813
#include <dhcp6/ctrl_dhcp6_srv.h>
14+
#include <dhcp6/dhcp6_srv.h>
1915
#include <dhcp6/json_config_parser.h>
2016
#include <dhcp6/tests/dhcp6_test_utils.h>
2117
#include <dhcp6/tests/get_config_unittest.h>
18+
#include <dhcpsrv/cfgmgr.h>
2219
#include <testutils/gtest_utils.h>
23-
24-
#include <boost/algorithm/string.hpp>
25-
#include <gtest/gtest.h>
20+
#include <testutils/user_context_utils.h>
2621

2722
#include <iostream>
28-
#include <string>
29-
#include <sstream>
3023
#include <list>
24+
#include <sstream>
25+
#include <string>
26+
27+
#include <boost/algorithm/string.hpp>
28+
29+
#include <gtest/gtest.h>
3130

3231
using namespace isc::config;
3332
using namespace isc::data;

src/bin/dhcp6/tests/get_config_unittest.cc.skel

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,24 @@
99
#include <cc/command_interpreter.h>
1010
#include <cc/data.h>
1111
#include <cc/simple_parser.h>
12-
#include <cc/cfg_to_element.h>
13-
#include <testutils/user_context_utils.h>
1412
#include <dhcp/testutils/iface_mgr_test_config.h>
15-
#include <dhcpsrv/cfgmgr.h>
16-
#include <dhcpsrv/parsers/simple_parser6.h>
17-
#include <dhcp6/dhcp6_srv.h>
1813
#include <dhcp6/ctrl_dhcp6_srv.h>
14+
#include <dhcp6/dhcp6_srv.h>
1915
#include <dhcp6/json_config_parser.h>
2016
#include <dhcp6/tests/dhcp6_test_utils.h>
2117
#include <dhcp6/tests/get_config_unittest.h>
18+
#include <dhcpsrv/cfgmgr.h>
2219
#include <testutils/gtest_utils.h>
23-
24-
#include <boost/algorithm/string.hpp>
25-
#include <gtest/gtest.h>
20+
#include <testutils/user_context_utils.h>
2621

2722
#include <iostream>
28-
#include <string>
29-
#include <sstream>
3023
#include <list>
24+
#include <sstream>
25+
#include <string>
26+
27+
#include <boost/algorithm/string.hpp>
28+
29+
#include <gtest/gtest.h>
3130

3231
using namespace isc::config;
3332
using namespace isc::data;

0 commit comments

Comments
 (0)