Expand line number match to a range of lines #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxtacles
approved these changes
Jan 4, 2025
jonschz
reviewed
Jan 4, 2025
foxtacles
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #57.
I had planned to eventually drop the sample files tested in
test_parser_samples.pybut this is one of the only places we actually test that the line numbers are captured correctly. I had some comments warning about detecting the end line of the function; this seems to work okay (with Allman syntax) so I enabled the tests for those. I don't think it's possible forend_lineto beNonebut I will save that refactor for later.The lines database definitely needs improvement (related to #53) but that's not for this PR.