Download and use 16-bit SkiFree for NE tests #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3. We sort of landed on using existing binaries to test the binary image processing rather than concocting examples ourselves, at least for now.
SkiFree needs no introduction and the EXE is small. To test locally you can get the 16-bit version from Chris Pirih's site, from archive.org, or some old floppy disk you have on hand.
This fixes a bug with NE header unpacking and adds some rudimentary tests. I didn't expand the functionality yet because I'm not sure how we should handle 16-bit addresses.
We cache the download but the cache is not shared between branches so maybe using archive.org is not the best thing long-term. As we add more sample binaries we may want to parameterize the CI task and the way we load the files using
pytest
. Is that something we should figure out now or later?