Store diffs in JSON report, HTML export for reccmp-aggregate
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new features to help the entropy runs over at isledecomp:
The
--jsonoption forreccmp-reccmpnow inserts diff information in the JSON report by default. This is the same data that has been included in the HTML reports. This doesn't seem to cause much of an impact other than increasing the report file size, which is why I enabled it by default. Deserializing the report with--diffis a tad slower (~100ms for me) so if you want the old behavior, add the parameter--json-diet. Adding diffs to the JSON is backward compatible with our current schema, so the version stays at 1.The other component is the
--htmloption forreccmp-aggregate. Now that we have the diffs in the JSON report, we can also generate an HTML report with the diff of the best match from each of the samples. In other words, for functions that still don't match, we can now see why and decide for ourselves if it's entropy not addressed by the effective match code.Lastly, we had previously dropped the recomp addr when aggregating reports. In the rare occasion that it is the same in all reports, we now keep it. Otherwise, we use the string "various".