linux/concept: af-xdp concept fixes #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the following typos: * one can implementing => one can implement * lets walk => let's walk * only the some of => only some of * is is set => is set * the size of (...) need to => the size of (...) needs to * the case were we => the case where we * suck as => such as * 1024 ect => 1024 etc * to never (...) checks => to never (...) check * rater the process => rather the process * between between => between * set he => set the * to no instantiate => to not instantiate Signed-off-by: Rodrigo Cataldo <rodrigo.cadore@l-acoustics.com>
Always use the same article for XDP: an (assuming a reading of /ex-dee-pee/) Signed-off-by: Rodrigo Cataldo <rodrigo.cadore@l-acoustics.com>
The adverb therefor is typically used as a synonym to therefore; however, it is not always so (at least in legal documents). Just use the adverb therefore directly. Signed-off-by: Rodrigo Cataldo <rodrigo.cadore@l-acoustics.com>
Assuming a struct called S and a variable called V, sizeof(S) is valid C++, but not valid C. We can either use sizeof(struct S) or sizeof(V). Use the latter to fix the C code samples. Signed-off-by: Rodrigo Cataldo <rodrigo.cadore@l-acoustics.com>
dylandreimerink
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR has a number of fixes for the AF_XDP concept page.
The first commit is a collection of typos. I think they are not controversial, so I put them together.
The second commit homogenize the article before the word XDP; before, sometimes it was "a xdp", sometimes it was "an XDP".
The third commit swaps therefor to therefore for clarify.
Finally, the fourth commit fixes two C code samples regarding the use of
sizeof()with structures.PS: Following the same rule as commit 2, we should also use "An XSK". But, for this acronym, the text always used "a XDK". So i did not think it was worth changing it.