Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update refdocs to use markdown links and standardize HTTP/2 notation in master #3430

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

AdeshGhadage
Copy link

Converted inline URLs to markdown format in refdocs. Standardized "HTTP2" to "HTTP/2". Changes made in the master branch of istio/api. This aligns with issue #16102.

@AdeshGhadage AdeshGhadage requested a review from a team as a code owner February 4, 2025 13:09
@istio-policy-bot
Copy link

😊 Welcome @AdeshGhadage! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Feb 4, 2025
@istio-testing
Copy link
Collaborator

Hi @AdeshGhadage. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zirain
Copy link
Member

zirain commented Feb 4, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 4, 2025
@craigbox
Copy link
Contributor

craigbox commented Feb 4, 2025

Please bring the URL changes from #3431 into this PR and we can proceed. Check each URL, as the first one I tried was 404.

Copy link
Contributor

@craigbox craigbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
You can add the "release-notes-none" label for this as nothing you have changed requires a release note entry.

AdeshGhadage and others added 4 commits February 6, 2025 22:34
Co-authored-by: Craig Box <craig.box@gmail.com>
Co-authored-by: Craig Box <craig.box@gmail.com>
Co-authored-by: Craig Box <craig.box@gmail.com>
@AdeshGhadage
Copy link
Author

I think i don't have permission to add label "release-notes-none"

@craigbox
Copy link
Contributor

craigbox commented Feb 7, 2025

/release-note-none

(I understand the commands that are listed here, apparently)

@AdeshGhadage
Copy link
Author

/release-note-none

@zirain zirain added the release-notes-none Indicates a PR that does not require release notes. label Feb 7, 2025
@zirain
Copy link
Member

zirain commented Feb 7, 2025

/test release-notes

@craigbox
Copy link
Contributor

craigbox commented Feb 7, 2025

(someone should raise an issue that the bot should have done this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants