Skip to content

Commit 2cdfe08

Browse files
committed
Merge branch 'Buthrakaur-patch-1'
* Buthrakaur-patch-1: Added back for Backward-Compat but without @OverRide removed createJSModules method (RN 0.47 breaking change)
2 parents 89abc60 + 970384c commit 2cdfe08

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

android/src/main/java/com/rnfs/RNFSPackage.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,15 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte
1616
modules.add(new RNFSManager(reactContext));
1717
return modules;
1818
}
19-
20-
@Override
21-
public List<Class<? extends JavaScriptModule>> createJSModules() {
22-
return Collections.emptyList();
19+
20+
// deprecated >= RN 0.47.0
21+
public List<Class<? extends JavaScriptModule>> createJSModules() {
22+
return Collections.emptyList();
2323
}
2424

2525
@Override
2626
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
2727
return Arrays.<ViewManager>asList();
2828
}
29+
2930
}

0 commit comments

Comments
 (0)