Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic code error (LwjglCanvas - LWJGL3) #2238

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Logic code error (LwjglCanvas - LWJGL3) #2238

merged 1 commit into from
Mar 30, 2024

Conversation

JNightRider
Copy link
Contributor

@JNightRider JNightRider commented Mar 28, 2024 •
edited
Loading

This PR is to remove a 'redundancy' in the size depth settings in LwjglCanvas

...
[Line 500] glData.depthSize = settings.getBitsPerPixel();
...
[Line 504] glData.depthSize = settings.getDepthBits();

It doesn't cause any problems but it is better to clean it.

stephengold
stephengold approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@stephengold stephengold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@scenemax3d scenemax3d added this to the v3.7.0 milestone Mar 30, 2024
@scenemax3d scenemax3d merged commit 3a556b5 into jMonkeyEngine:master Mar 30, 2024
14 checks passed
@JNightRider JNightRider deleted the LwjglCanvas_logical_error] branch March 30, 2024 19:26
scenemax3d pushed a commit that referenced this pull request Mar 30, 2024
@JNightRider @scenemax3d
Logic code error (#2238)
2d3b3ce 
 remove a 'redundancy' in the size depth settings in LwjglCanvas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengold stephengold stephengold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JNightRider @stephengold @scenemax3d