-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context param attributes to @FacesConfig #1878
Closed
BalusC
wants to merge
1,802
commits into
5.0
from
faces_issue_1416_add_context_param_attributes_to_FacesConfig
Closed
Add context param attributes to @FacesConfig #1878
BalusC
wants to merge
1,802
commits into
5.0
from
faces_issue_1416_add_context_param_attributes_to_FacesConfig
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ improved and unified Factory and Function with Cache Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
+ little optimizations... still a bit ugly Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
Skip already-processed documents in case multiple ConfigurationResourceProviders return same documents
Don't attempt to reconfigure PartialResponseWriter when it's already committed
StringBuffer -> StringBuilder
Java modernizations
UrlBuilder: Charset instead of String
Utils: improvements and new functions
static initializations with List.of( ... )
LRUCache + ELUtils
[5262] Do not set the response buffer size if set to -1.
[5262] Do not set the response buffer size if set to -1.
"final" on effective final fields
Added one more condition to ResourceHandlerImpl#isConnectionAbort()
fixed websocket url with https protocol url protocol replace without regex Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
+ various optimizations Signed-off-by: pizzi80 <paolo@given2.com>
PhaseId optimization
ExternalContextImpl optimization
getter/setter as UIRepeat is going to be moved into API of Faces.next #1263
Bump to Java 17
…te_composite-extension Deprecate <composite:extension>
faces_issue_1263_add_rowStatePreserved_to_UIRepeat_faces5
…atePreserved_to_UIRepeat Add rowStatePreserved property to UIRepeat, exactly the same as UIData
…atePreserved_to_UIRepeat_faces5 Add rowStatePreserved property to UIRepeat
setCurrentInstance() and releaseCurrentInstance() at right moments
noted should be that these tests were very helpful to validate changes in InitFacesContext
compared to PostConstruct
Use CDI as injection provider and fixed InitFacesContext
faces_issue_1416_add_context_param_attributes_to_FacesConfig
'mojarra/faces_issue_1416_add_context_param_attributes_to_FacesConfig' into faces_issue_1416_add_context_param_attributes_to_FacesConfig
Hmm, 1802 commits?! Looks like merging from Mojarra branch into Faces branch isn't working out as I expected. I guess I'll have to cherrypick instead. |
mnriem
reviewed
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1416
Originally in Mojarra project eclipse-ee4j/mojarra#5344, but then API was split into Faces project, so I had to catch up that.