Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context param attributes to @FacesConfig #1878

Closed

Conversation

BalusC
Copy link
Member

@BalusC BalusC commented Feb 10, 2024

#1416

Originally in Mojarra project eclipse-ee4j/mojarra#5344, but then API was split into Faces project, so I had to catch up that.

pizzi80 and others added 30 commits June 25, 2023 17:37
+ improved and unified Factory and Function with Cache

Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
+ little optimizations... still a bit ugly

Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
Skip already-processed documents in case multiple ConfigurationResourceProviders return same documents
Don't attempt to reconfigure PartialResponseWriter when it's already committed
UrlBuilder: Charset instead of String
Utils: improvements and new functions
static initializations with List.of( ... )
[5262] Do not set the response buffer size if set to -1.
[5262] Do not set the response buffer size if set to -1.
Added one more condition to ResourceHandlerImpl#isConnectionAbort()
fixed websocket url with https protocol
url protocol replace without regex

Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
+ various optimizations

Signed-off-by: pizzi80 <paolo@given2.com>
BalusC and others added 22 commits November 4, 2023 17:20
getter/setter as UIRepeat is going to be moved into API of Faces.next
#1263
…te_composite-extension

Deprecate <composite:extension>
faces_issue_1263_add_rowStatePreserved_to_UIRepeat_faces5
…atePreserved_to_UIRepeat

Add rowStatePreserved property to UIRepeat, exactly the same as UIData
…atePreserved_to_UIRepeat_faces5

Add rowStatePreserved property to UIRepeat
…njection_of_current_flow

Support @Inject of current flow like "@Inject Flow currentFlow"
setCurrentInstance() and releaseCurrentInstance() at right moments
noted should be that these tests were very helpful to validate changes
in InitFacesContext
Use CDI as injection provider and fixed InitFacesContext
faces_issue_1416_add_context_param_attributes_to_FacesConfig
'mojarra/faces_issue_1416_add_context_param_attributes_to_FacesConfig'
into faces_issue_1416_add_context_param_attributes_to_FacesConfig
@BalusC BalusC changed the base branch from master to 5.0 February 10, 2024 20:27
@BalusC
Copy link
Member Author

BalusC commented Feb 10, 2024

Hmm, 1802 commits?! Looks like merging from Mojarra branch into Faces branch isn't working out as I expected. I guess I'll have to cherrypick instead.

@BalusC BalusC closed this Feb 10, 2024
@BalusC BalusC deleted the faces_issue_1416_add_context_param_attributes_to_FacesConfig branch February 10, 2024 20:36
Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants