use new google maps api url and allow specifying the gmaps api key #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the great php dashboard!
When I first setup mondoweb the map wouldn't load (would get some default grey map tiles) and there were errors in the console about not having the google maps api key set.
After doing a bit of digging the map started working again as soon as I changed the url to the new maps.googleapis.com url.
I have also created a google maps api key and the errors about 'NoApiKeys' has disappeared. While the key is not mandatory, Google recommends setting it. I have added an extra variable in settings.php for it.
A key can be created here: https://developers.google.com/maps/documentation/javascript/get-api-key
I also removed 'sensor=true' from the url as that is not supported any more and it throws a warning in console:
Google Maps API warning: SensorNotRequired https://developers.google.com/maps/documentation/javascript/error-messages#sensor-not-required
I've only just started contributing back to projects, so I'm practicing with smaller commits :)