Update exceptions.rst #1038
Open
Update exceptions.rst #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove vestigial line referring to code that has since changed. remove() used to throw an exception for an empty bag, but now it just returns a sentinel value
| @@ -110,7 +110,6 @@ Catching Exceptions | |||
| * If someone is using the ``ArraySortedBag`` implementation two years from now, it's not possible to know what they should do to manage the exceptional situations | |||
| * The users of the ``ArraySortedBag`` class will need to deal with them as they see fit | |||
|
|
|||
| * What should be done if calling ``remove`` on an empty ``ArraySortedBag``? | |||
There was a problem hiding this comment.
Things would need to be rewritten a little --- It needs to be
"What should be done if calling removeFirst on an empty ArraySortedBag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove vestigial line referring to code that has since changed. remove() used to throw an exception for an empty bag, but now it just returns false because the element that was called to be removed was not present in the bag