macOS support improvements #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stealthii
force-pushed
the
feature/macos-support
branch
from
5d8f5d7 to
a5abadd
Compare
janoamaral
requested changes
Apr 13, 2024
In order to navigate rendering issues from raw data in nowplaying-cli, the output has been switched to use named properties in an associative array. Included is a fix to playback state based on rate, handling playback at different speeds. This will require bash v4 or higher.
This change includes a fix for durations over 1 hour, where the time is updated to the dashed variant rather than rolling over each hour.
Flattened requirements into one clear list, with sections provided for OS flavors.
Stealthii
force-pushed
the
feature/macos-support
branch
from
d563fad to
bcd2992
Compare
uNyanda
pushed a commit
to uNyanda/tokyo-night-tmux
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores macOS compatibility, and fixes a few remaining issues with current widgets.
Major changes
Minor changes
Bug & security fixes
Additional information
A dependency on GNU coreutils/bc, and Bash 4+ is implied with this update. The bash requirement only affects macOS at present, however Homebrew instructions are being provided for dependencies and use of this package manager is assumed to provide tmux and other utilities that are already used by this theme.