git-status performance and safety fixes #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stealthii
force-pushed
the
bugfix/git-status-perf
branch
from
bf43f31 to
1a9a6a3
Compare
janoamaral
requested changes
Apr 13, 2024
Stealthii
force-pushed
the
bugfix/git-status-perf
branch
from
1a9a6a3 to
01e9310
Compare
egrep is non-standard and deprecated, use grep -E instead.
Replace use of string comparisons with -gt, -pt, and -eq. This fixes an issue with git-status where the 20 second time comparison wasn't adhered to.
Previously STATUS wasn't checked properly in cases where the command failed, resulting in incorrect output. This has been replaced with a numerical check which will ensure the correct output in both situations.
Stealthii
force-pushed
the
bugfix/git-status-perf
branch
from
01e9310 to
a92e057
Compare
|
Confirmed functionality on personal master branch! Updated a few known color references to the new theme variants. |
janoamaral
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for this PR is that due to the sheer number of calls to git during these calculations, actual git commands were failing due to the locks. Multiple commands have been replaced with single, lock-safe checks and other comparisons made to reduce calls to upstream fixed.
Minor changes
Bug & security fixes