Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance battery widget with cross-platform support and improved logic #96

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

LockeAG
Copy link
Contributor

@LockeAG LockeAG commented Jun 16, 2024

Summary

This pull request enhances the battery widget script, making it more robust and compatible with various operating systems. The following improvements have been made:

  • Added cross-platform support: The script now supports Windows environments (Cygwin, MinGW, MSYS, Windows_NT).
  • Improved logic: The logic to fetch and handle battery status and percentage has been improved for better accuracy across different OS types.
  • Robust checks: Added robust checks for battery presence and user-friendly output when no battery is detected.

Changes

  • Enhanced the battery widget script with additional support for various Windows environments.
  • Improved the method for fetching battery status and percentage to ensure accurate readings.
  • Added checks to handle scenarios where no battery is detected, providing clear output to the user.

Issue

Closes #77

Thank you for considering this contribution to the tokyo-night-tmux project. Please let me know if you have any questions or need further improvements.

LockeAG added 2 commits June 16, 2024 01:14
- Added cross-platform support for Windows environments (Cygwin, MinGW, MSYS, Windows_NT).
- Improved logic to fetch and handle battery status and percentage accurately across different OS types.
- Added robust checks for battery presence and user-friendly output when no battery is detected.

This pull request enhances the battery widget script, making it more robust and compatible with various operating systems, thereby improving its overall reliability and usability.
- Added cross-platform support for Windows environments (Cygwin, MinGW, MSYS, Windows_NT).
- Improved logic to fetch and handle battery status and percentage accurately across different OS types.
- Added robust checks for battery presence and user-friendly output when no battery is detected.

This pull request enhances the battery widget script, making it more robust and compatible with various operating systems, thereby improving its overall reliability and usability.

Closes janoamaral#77
@janoamaral janoamaral added the enhancement New feature or request label Jun 16, 2024
@janoamaral janoamaral merged commit 2bc3fce into janoamaral:next Jun 30, 2024
9 checks passed
@LockeAG LockeAG deleted the enhance-battery-widget branch September 25, 2024 06:47
uNyanda pushed a commit to uNyanda/tokyo-night-tmux that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants