Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete linaria #36

Merged
merged 8 commits into from
May 17, 2024
Merged

delete linaria #36

merged 8 commits into from
May 17, 2024

Conversation

jantimon
Copy link
Owner

@jantimon jantimon commented May 16, 2024

I have updated our repository to work with the latest version of Next.js by attempting to integrate Linaria. Unfortunately, there is no official Next.js integration available on the Linaria repositiory at the moment: https://github.com/callstack/linaria?tab=readme-ov-file#setup

To address this, I used the package next-with-linaria, which successfully made the application compatible with the current versions of Node.js and Next.js. However, I encountered issues with the builds being unreliable. On the first run, I received the error: Make sure you are not using a browser or Node specific API and all the variables are available in static context. On the second run, the build was successful. I suspect this inconsistency arises from an incomplete integration with Next.js's build process, leading to poor compatibility with css-variables.

To ensure the pipeline remains green, I have temporarily removed the Linaria example. I am open to re-adding it if the compatibility issues are resolved in funture

@jantimon jantimon changed the title fix linaria delete linaria May 17, 2024
@jantimon jantimon requested a review from martindisch May 17, 2024 06:46
Copy link
Collaborator

@martindisch martindisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks!

@jantimon jantimon merged commit a743353 into main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants