Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix esm for webpack #41

Closed
wants to merge 3 commits into from
Closed

Conversation

rvetere
Copy link
Collaborator

@rvetere rvetere commented Oct 18, 2024

All previous changes are upgrading the package to ESM, but it still breaks when we try to load the package as a module with the webpack loader. It is now clear that all the changes that were needed for jest are causing this. This pull request will reset the changes for jest, making it possible to load the package with webpack loader and we simply kick out jest in favor of vitest.

@jantimon
Copy link
Owner

I don’t think that a small package like css-variable should dictate the testing stack of a project

@rvetere
Copy link
Collaborator Author

rvetere commented Oct 18, 2024

i'm not talking about kicking out jest in our iso monorepo, i'm talking about switching css-variable from jest to vitest... i didn't push the changeset actually doing that yet because i still have an issue with one snapshot test after the switch

@rvetere rvetere closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants