Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of updates #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jwgmeligmeyling
Copy link
Contributor

The associated PR applies some changes that we have made to the local fork we using. It may not be useful to others, but I figured I could at least put it out here. Changes made:

  • Remove dependency on commons-io (could easily be omitted, and avoids conflicts in application servers that serve other versions of commons io)
  • Altered IBAN validation. I don't exactly remember why, but as far as I remember, in the previous library, I had some invalid IBANs ending up in the SEPA batch and therefore failing the entire thing. But I am not entirely sure anymore.
  • Migration to Java 8, and use of Java 8's date time API so that dependency on Joda time could be removed

In the last I've decided to go for LocalDateTime as opposed to their zoned counterpart. While I think (but not am entirely sure) the XML format support zoned timestamps fine, I wanted to stay closes as possible to the original code and make the tests pass without tempering with the provided XML files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant