Making TaskNotFoundException more informative by adding task name to exception object.

Author: mekras

lib/phake/Node.php

@@ -150,7 +150,7 @@ public function get_task($task_name) {
             } else if ($this->parent) {
                 return $this->parent->get_task($task_name);
             } else {
-                throw new TaskNotFoundException;
+                throw TaskNotFoundException::create($task_name);
             }
 
         } else {

lib/phake/TaskNotFoundException.php

@@ -2,4 +2,45 @@
 
 namespace phake;
 
-class TaskNotFoundException extends \Exception {};
+use Exception;
+
+class TaskNotFoundException extends Exception
+{
+    /**
+     * Task name
+     *
+     * @var string
+     */
+    private $taskName;
+
+    /**
+     * Factory method for creating new exceptions
+     *
+     * @param string    $taskName name of task which is not found
+     * @param int       $code     exception code
+     * @param Exception $previous previous exception used for the exception chaining
+     *
+     * @return TaskNotFoundException
+     */
+    public static function create($taskName, $code = 0, Exception $previous = null)
+    {
+        $message = sprintf('Task "%s" not found', $taskName);
+        if (version_compare(PHP_VERSION, '5.4', '<')) {
+            $exception = new self($message, $code, $previous);
+        } else {
+            $exception = new static($message, $code, $previous);
+        }
+        $exception->taskName = $taskName;
+        return $exception;
+    }
+
+    /**
+     * Return name of not founded task
+     *
+     * @return string
+     */
+    public function getTaskName()
+    {
+        return $this->taskName;
+    }
+}

tests/TaskNotFoundExceptionTest.php

@@ -0,0 +1,34 @@
+<?php
+
+use phake\TaskNotFoundException;
+
+/**
+ * Tests of phake\TaskNotFoundException
+ *
+ * @covers phake\TaskNotFoundException
+ */
+class TaskNotFoundExceptionTest extends PHPUnit_Framework_TestCase
+{
+    /**
+     * Test factory method
+     *
+     * @covers phake\TaskNotFoundException::create
+     */
+    public function testCreate()
+    {
+        $e = TaskNotFoundException::create('foo');
+        $this->assertInstanceOf('phake\TaskNotFoundException', $e);
+        $this->assertEquals('Task "foo" not found', $e->getMessage());
+    }
+
+    /**
+     * Test getTaskName
+     *
+     * @covers phake\TaskNotFoundException::getTaskName
+     */
+    public function testGetTaskName()
+    {
+        $e = TaskNotFoundException::create('foo');
+        $this->assertEquals('foo', $e->getTaskName());
+    }
+}