Webpushes timeout

README.rst

@@ -129,7 +129,7 @@ For WNS, you need both the ``WNS_PACKAGE_SECURITY_KEY`` and the ``WNS_SECRET_KEY
 
 - ``WP_PRIVATE_KEY``: Absolute path to your private certificate file: os.path.join(BASE_DIR, "private_key.pem")
 - ``WP_CLAIMS``: Dictionary with default value for the sub, (subject), sent to the webpush service, This would be used by the service if they needed to reach out to you (the sender). Could be a url or mailto e.g. {'sub': "mailto:development@example.com"}.
-- ``WP_ERROR_TIMEOUT``: The timeout on WebPush POSTs. (Optional)
+- ``WP_ERROR_TIMEOUT``: The timeout on WebPush POSTs. (Optional, default value is 1 second)
 
 For more information about how to configure WebPush, see `docs/WebPush <https://github.com/jazzband/django-push-notifications/blob/master/docs/WebPush.rst>`_.
 

push_notifications/conf/app.py

@@ -218,6 +218,7 @@ def _validate_wp_config(self, application_id, application_config):
 			"EDGE": "https://wns2-par02p.notify.windows.com/w",
 			"FIREFOX": "https://updates.push.services.mozilla.com/wpush/v2",
 		})
+		application_config.setdefault("ERROR_TIMEOUT", 1)
 
 	def _validate_allowed_settings(self, application_id, application_config, allowed_settings):
 		"""Confirm only allowed settings are present."""
@@ -349,3 +350,6 @@ def get_wp_private_key(self, application_id=None):
 
 	def get_wp_claims(self, application_id=None):
 		return self._get_application_settings(application_id, "WP", "CLAIMS")
+
+	def get_wp_error_timeout(self, application_id=None):
+		return self._get_application_settings(application_id, "WP", "ERROR_TIMEOUT")

push_notifications/conf/legacy.py

@@ -128,3 +128,7 @@ def get_wp_private_key(self, application_id=None):
 	def get_wp_claims(self, application_id=None):
 		msg = "Setup PUSH_NOTIFICATIONS_SETTINGS properly to send messages"
 		return self._get_application_settings(application_id, "WP_CLAIMS", msg)
+
+	def get_wp_error_timeout(self, application_id=None):
+		msg = "Setup PUSH_NOTIFICATIONS_SETTINGS properly to set a timeout"
+		return self._get_application_settings(application_id, "WP_ERROR_TIMEOUT", msg)

push_notifications/settings.py

@@ -40,7 +40,7 @@
 })
 PUSH_NOTIFICATIONS_SETTINGS.setdefault("WP_PRIVATE_KEY", None)
 PUSH_NOTIFICATIONS_SETTINGS.setdefault("WP_CLAIMS", None)
-PUSH_NOTIFICATIONS_SETTINGS.setdefault("WP_ERROR_TIMEOUT", None)
+PUSH_NOTIFICATIONS_SETTINGS.setdefault("WP_ERROR_TIMEOUT", 1)
 
 # User model
 PUSH_NOTIFICATIONS_SETTINGS.setdefault("USER_MODEL", settings.AUTH_USER_MODEL)

push_notifications/webpush.py

@@ -37,6 +37,7 @@ def webpush_send_message(device, message, **kwargs):
 			data=message,
 			vapid_private_key=get_manager().get_wp_private_key(device.application_id),
 			vapid_claims=get_manager().get_wp_claims(device.application_id).copy(),
+			timeout=get_manager().get_wp_error_timeout(device.application_id),
 			**kwargs
 		)
 		if response.ok: