Skip to content

Commit 4ad92d6

Browse files
committed
fix: flow and eslint errors
1 parent c2c2b3c commit 4ad92d6

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

src/createNumericField.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,18 @@
11
// @flow
22

33
import * as React from 'react'
4+
import type {FieldProps} from 'redux-form'
45

56
type NumberNormalizer = (value: ?(string | number)) => ?(string | number)
67
type Validator = (value: any, allValues: Object, props: Object) => ?any
78
const WHITESPACE = /^\s*$/
89

910

10-
function createNumericField<P: {validate?: Validator | Array<Validator>, normalizeOnBlur?: Function}>(
11+
function createNumericField<P: {
12+
validate?: Validator | Array<Validator>,
13+
normalizeOnBlur?: Function,
14+
component: React.ElementType | Function | string,
15+
}>(
1116
Field: React.ComponentType<P>
1217
): React.ComponentType<P & {normalizeNumber?: NumberNormalizer}> {
1318
type Props = React.ElementProps<typeof Field> & {normalizeNumber?: NumberNormalizer}
@@ -46,14 +51,13 @@ function createNumericField<P: {validate?: Validator | Array<Validator>, normali
4651
}
4752
}
4853

49-
KeyDownHandler = ({input, onKeyDown, ...props}) => {
54+
KeyDownHandler = ({input, onKeyDown, ...props}: FieldProps & {onKeyDown?: (event: Event) => any}): React.Node => {
5055
const Comp = this.props.component
51-
5256
return (
5357
<Comp
5458
{...props}
5559
input={input}
56-
onKeyDown={(event: KeyEvent) => {
60+
onKeyDown={(event: Event) => {
5761
const normalizeNumber = this.props.normalizeNumber || defaultNormalize
5862
if (event.keyCode === 13) {
5963
input.onChange(normalizeNumber(input.value))

test/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {reduxForm as immutableReduxForm, reducer as immutableReducer} from 'redu
1212
import {NumericField} from '../src'
1313
import {NumericField as ImmutableNumericField} from '../src/immutable'
1414

15-
const Input = ({input: inputProps, innerRef, ...props}): React.Node => <input {...inputProps} {...props} ref={innerRef} />
15+
const Input = ({input: inputProps, ...props}): React.Node => <input {...inputProps} {...props} />
1616

1717
function min(threshold: number): (value: number) => ?string {
1818
return (value: number) => {
@@ -226,13 +226,11 @@ describe('NumericField', () => {
226226
it('normalizes when enter is pressed', () => {
227227
const store = createStore(combineReducers({form: reducer}))
228228

229-
let input
230229
const Form = reduxForm({form: 'form'})(() => (
231230
<form>
232231
<NumericField
233232
name="hello"
234233
component={Input}
235-
innerRef={c => input = c}
236234
/>
237235
</form>
238236
))

0 commit comments

Comments
 (0)