use in operator instead of hasOwnProperty (#1094)

Author: jelhan

.eslintrc.js

@@ -20,13 +20,6 @@ module.exports = {
     // want new controllers to be added again unless needed for query
     // parameter handling.
     'ember/no-controllers': 'error',
-    // Croodle is not compliant with some of the recommended rules yet.
-    // We should refactor the code step by step and enable them as soon
-    // as the code is compliant.
-    'ember/classic-decorator-no-classic-methods': 'warn',
-    'ember/no-controller-access-in-routes': 'warn',
-    'ember/no-observers': 'warn',
-    'no-prototype-builtins': 'warn',
   },
   overrides: [
     // ts files

mirage/serializers/application.js

@@ -25,21 +25,18 @@ export default RestSerializer.extend({
       if (key === 'id') {
         // records id
         jsonApiPayload.data.id = attrs.id;
-      } else if (
-        belongsToAssociations.hasOwnProperty(key) ||
-        hasManyAssociations.hasOwnProperty(key)
-      ) {
+      } else if (key in belongsToAssociations || key in hasManyAssociations) {
         // relationship
-        if (!jsonApiPayload.data.hasOwnProperty('relationships')) {
+        if (!('relationships' in jsonApiPayload.data)) {
           jsonApiPayload.data.relationships = {};
         }
 
-        let association = belongsToAssociations.hasOwnProperty(key)
-          ? belongsToAssociations[key]
-          : hasManyAssociations[key];
-        let associationType = belongsToAssociations.hasOwnProperty(key)
-          ? 'belongsTo'
-          : 'hasMany';
+        let association =
+          key in belongsToAssociations
+            ? belongsToAssociations[key]
+            : hasManyAssociations[key];
+        let associationType =
+          key in belongsToAssociations ? 'belongsTo' : 'hasMany';
         let associationModel = association.modelName;
         let relationshipObject = {};
 
@@ -64,7 +61,7 @@ export default RestSerializer.extend({
         jsonApiPayload.data.relationships[key] = relationshipObject;
       } else {
         // attribute
-        if (!jsonApiPayload.data.hasOwnProperty('attributes')) {
+        if (!('attributes' in jsonApiPayload.data)) {
           jsonApiPayload.data.attributes = {};
         }