Skip to content

Commit c68b11a

Browse files
Update dependency eslint-plugin-ember to v12 (#856)
* Update dependency eslint-plugin-ember to v12 * disable the problematic ESLint rule for this case --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jeldrik Hanschke <admin@jhanschke.de>
1 parent cf4bb42 commit c68b11a

File tree

3 files changed

+158
-32
lines changed

3 files changed

+158
-32
lines changed

app/helpers/scroll-first-invalid-element-into-view-port.ts

+7
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,13 @@ const scrollFirstInvalidElementIntoViewPort = helper(() => {
3737
// `schedule('afterRender', function() {})` would be more approperiate but there seems to be a
3838
// timing issue in Firefox causing the Browser not scrolling up far enough if doing so
3939
// delaying to next runloop therefore
40+
//
41+
// This should be refactored at a later point in time to an utility function. At that point
42+
// we may consider refactoring it to use a wrapper such as Ember Lifeline easing usage of the
43+
// Ember's runloop API. Due to the specifics of this use case - especially calling only native
44+
// browser APIs and no Ember code - typical pitfalls of Ember's runloop do not apply in this case.
45+
//
46+
// eslint-disable-next-line ember/no-runloop
4047
next(function () {
4148
const invalidInput = document.querySelector(
4249
'.form-control.is-invalid, .custom-control-input.is-invalid',

package-lock.json

+150-31
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
"ember-truth-helpers": "4.0.3",
9292
"eslint": "8.57.1",
9393
"eslint-config-prettier": "9.1.0",
94-
"eslint-plugin-ember": "11.12.0",
94+
"eslint-plugin-ember": "12.5.0",
9595
"eslint-plugin-n": "16.6.2",
9696
"eslint-plugin-prettier": "5.2.3",
9797
"eslint-plugin-qunit": "8.1.2",

0 commit comments

Comments
 (0)