Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swipe to auto-brightness at 0% in exoPlayer #1348

Closed
wants to merge 1 commit into from

Conversation

stm91
Copy link

@stm91 stm91 commented Apr 14, 2024

Changes

  • enhances PlayerGestureHelper to allow swiping past 0% brightness to restore auto brightness from system
  • adds "A" ui-indicator to brightness overlay when auto-brightness is enabled

Screen_Recording_20240414_174344_Jellyfin Debug

Issues

@jellyfin-bot jellyfin-bot added this to the v2.7.0 milestone Apr 14, 2024
@Maxr1998
Copy link
Member

Hi, thanks for your contribution. We're in the process of migrating the player to Jetpack Compose (see the compose-player branch for details), so it unfortunately doesn't make sense to merge your PR. However, I like the concept behind it and will incorporate the feature in the rewritten player later on.

@stm91 stm91 closed this Apr 16, 2024
@nielsvanvelzen nielsvanvelzen removed this from the v2.7.0 milestone Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants