Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of blurry media images in notifications. #1493

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

peerless2012
Copy link
Contributor

Changes
Use MediaMetadata art to override large icon in notification, fix art not clear issue.

Before:
微信截图_20241011232259

After:
微信截图_20241011232400

@jellyfin-bot jellyfin-bot added this to the v2.7.0 milestone Oct 11, 2024
@peerless2012
Copy link
Contributor Author

The notification art is land, maybe use backdrop art resource?

Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR and bringing this issue to my attention. I'd argue that setting the metadata in the notification helper isn't the best location, but it is good enough for now.

I realized that the artwork loading can generally be improved by implementing a content provider, but this is out of scope for this PR.

Thus, I'll merge it as is. Thanks again!

@Maxr1998 Maxr1998 merged commit bec1680 into jellyfin:master Jan 25, 2025
1 check passed
@peerless2012 peerless2012 deleted the fix_notification_art branch January 26, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants